Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: components/suggestions/proto/suggestions.proto

Issue 2525653002: NewTabPage: Remove impression/click ping plumbing for local NTP (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 syntax = "proto2"; 5 syntax = "proto2";
6 6
7 option optimize_for = LITE_RUNTIME; 7 option optimize_for = LITE_RUNTIME;
8 8
9 package suggestions; 9 package suggestions;
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 optional string favicon_url = 3; 45 optional string favicon_url = 3;
46 46
47 // The URL of the thumbnail associated with this page. 47 // The URL of the thumbnail associated with this page.
48 optional string thumbnail = 4; 48 optional string thumbnail = 4;
49 49
50 // The provider(s) responsible for this suggestion. 50 // The provider(s) responsible for this suggestion.
51 repeated ProviderId providers = 5; 51 repeated ProviderId providers = 5;
52 52
53 // The timestamp (usec) at which this suggestion ceases to be valid. 53 // The timestamp (usec) at which this suggestion ceases to be valid.
54 optional int64 expiry_ts = 7; 54 optional int64 expiry_ts = 7;
55
56 // URL that should be pinged back when the suggestion is shown/clicked.
57 optional string impression_url = 13;
58 optional string click_url = 14;
mastiz 2016/11/28 13:46:22 Can you please either: a) Mark field tags 13 and 1
Marc Treib 2016/11/28 13:56:47 There already is a comment above ("Next tag: 15")
59 } 55 }
60 56
61 // A list of URLs that should be filtered from the SuggestionsProfile. 57 // A list of URLs that should be filtered from the SuggestionsProfile.
62 // 58 //
63 // Next tag: 2 59 // Next tag: 2
64 message SuggestionsBlacklist { 60 message SuggestionsBlacklist {
65 // URLs that make up the blacklist. 61 // URLs that make up the blacklist.
66 repeated string urls = 1; 62 repeated string urls = 1;
67 } 63 }
68 64
69 // ImageData contains the data to represent a website image (e.g. thumbnail). 65 // ImageData contains the data to represent a website image (e.g. thumbnail).
70 // 66 //
71 // Next tag: 3 67 // Next tag: 3
72 message ImageData { 68 message ImageData {
73 // The URL of the website represented by this image. 69 // The URL of the website represented by this image.
74 optional string url = 1; 70 optional string url = 1;
75 71
76 // Bitmap bytes, encoded as JPEG. 72 // Bitmap bytes, encoded as JPEG.
77 optional bytes data = 2; 73 optional bytes data = 2;
78 } 74 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698