Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: chrome/common/search/instant_types.h

Issue 2525653002: NewTabPage: Remove impression/click ping plumbing for local NTP (Closed)
Patch Set: undo JS changes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_SEARCH_INSTANT_TYPES_H_ 5 #ifndef CHROME_COMMON_SEARCH_INSTANT_TYPES_H_
6 #define CHROME_COMMON_SEARCH_INSTANT_TYPES_H_ 6 #define CHROME_COMMON_SEARCH_INSTANT_TYPES_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 // The title of the Most Visited page. May be empty, in which case the |url| 134 // The title of the Most Visited page. May be empty, in which case the |url|
135 // is used as the title. 135 // is used as the title.
136 base::string16 title; 136 base::string16 title;
137 137
138 // The external URL of the thumbnail associated with this page. 138 // The external URL of the thumbnail associated with this page.
139 GURL thumbnail; 139 GURL thumbnail;
140 140
141 // The external URL of the favicon associated with this page. 141 // The external URL of the favicon associated with this page.
142 GURL favicon; 142 GURL favicon;
143 143
144 // The external URL that should be pinged when this item is suggested/clicked.
145 GURL impression_url;
146 GURL click_url;
147
148 // True if it's a server side suggestion. 144 // True if it's a server side suggestion.
149 // Otherwise, it's a client side suggestion. 145 // Otherwise, it's a client side suggestion.
150 bool is_server_side_suggestion; 146 bool is_server_side_suggestion;
151 }; 147 };
152 148
153 // An InstantMostVisitedItem along with its assigned restricted ID. 149 // An InstantMostVisitedItem along with its assigned restricted ID.
154 typedef std::pair<InstantRestrictedID, InstantMostVisitedItem> 150 typedef std::pair<InstantRestrictedID, InstantMostVisitedItem>
155 InstantMostVisitedItemIDPair; 151 InstantMostVisitedItemIDPair;
156 152
157 // Embedded search request logging stats params. 153 // Embedded search request logging stats params.
(...skipping 26 matching lines...) Expand all
184 180
185 // The optional assisted query stats, aka AQS, used for logging purposes. 181 // The optional assisted query stats, aka AQS, used for logging purposes.
186 // This string contains impressions of all autocomplete matches shown 182 // This string contains impressions of all autocomplete matches shown
187 // at the query submission time. For privacy reasons, we require the 183 // at the query submission time. For privacy reasons, we require the
188 // search provider to support HTTPS protocol in order to receive the AQS 184 // search provider to support HTTPS protocol in order to receive the AQS
189 // param. 185 // param.
190 // For more details, see http://goto.google.com/binary-clients-logging. 186 // For more details, see http://goto.google.com/binary-clients-logging.
191 base::string16 assisted_query_stats; 187 base::string16 assisted_query_stats;
192 }; 188 };
193 #endif // CHROME_COMMON_SEARCH_INSTANT_TYPES_H_ 189 #endif // CHROME_COMMON_SEARCH_INSTANT_TYPES_H_
OLDNEW
« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698