Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

Issue 2498053002: Add field to monitor last visited time for each search engine (Closed)
Patch Set: Add unit test for last_visited field. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/settings_overrides/settings_overrides_ap i.h" 5 #include "chrome/browser/extensions/api/settings_overrides/settings_overrides_ap i.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 data->favicon_url = GURL(SubstituteInstallParam( 105 data->favicon_url = GURL(SubstituteInstallParam(
106 *search_provider.favicon_url, install_parameter)); 106 *search_provider.favicon_url, install_parameter));
107 } 107 }
108 data->safe_for_autoreplace = false; 108 data->safe_for_autoreplace = false;
109 if (search_provider.encoding) { 109 if (search_provider.encoding) {
110 data->input_encodings.clear(); 110 data->input_encodings.clear();
111 data->input_encodings.push_back(*search_provider.encoding); 111 data->input_encodings.push_back(*search_provider.encoding);
112 } 112 }
113 data->date_created = base::Time(); 113 data->date_created = base::Time();
114 data->last_modified = base::Time(); 114 data->last_modified = base::Time();
115 data->last_visited = base::Time();
Peter Kasting 2016/11/21 03:35:07 I don't really understand why |date_created| and |
ltian 2016/11/28 22:08:01 Done.
115 data->prepopulate_id = 0; 116 data->prepopulate_id = 0;
116 if (search_provider.alternate_urls) { 117 if (search_provider.alternate_urls) {
117 data->alternate_urls.clear(); 118 data->alternate_urls.clear();
118 for (size_t i = 0; i < search_provider.alternate_urls->size(); ++i) { 119 for (size_t i = 0; i < search_provider.alternate_urls->size(); ++i) {
119 if (!search_provider.alternate_urls->at(i).empty()) 120 if (!search_provider.alternate_urls->at(i).empty())
120 data->alternate_urls.push_back(SubstituteInstallParam( 121 data->alternate_urls.push_back(SubstituteInstallParam(
121 search_provider.alternate_urls->at(i), install_parameter)); 122 search_provider.alternate_urls->at(i), install_parameter));
122 } 123 }
123 } 124 }
124 return data; 125 return data;
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 286
286 template <> 287 template <>
287 void BrowserContextKeyedAPIFactory< 288 void BrowserContextKeyedAPIFactory<
288 SettingsOverridesAPI>::DeclareFactoryDependencies() { 289 SettingsOverridesAPI>::DeclareFactoryDependencies() {
289 DependsOn(ExtensionPrefsFactory::GetInstance()); 290 DependsOn(ExtensionPrefsFactory::GetInstance());
290 DependsOn(PreferenceAPI::GetFactoryInstance()); 291 DependsOn(PreferenceAPI::GetFactoryInstance());
291 DependsOn(TemplateURLServiceFactory::GetInstance()); 292 DependsOn(TemplateURLServiceFactory::GetInstance());
292 } 293 }
293 294
294 } // namespace extensions 295 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698