Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: components/search_engines/template_url_data.h

Issue 2498053002: Add field to monitor last visited time for each search engine (Closed)
Patch Set: Remove sync operations of last_visited field. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_DATA_H_ 5 #ifndef COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_DATA_H_
6 #define COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_DATA_H_ 6 #define COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_DATA_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 // 103 //
104 // NOTE: this may be 0, which indicates the TemplateURL was created before we 104 // NOTE: this may be 0, which indicates the TemplateURL was created before we
105 // started tracking creation time. 105 // started tracking creation time.
106 base::Time date_created; 106 base::Time date_created;
107 107
108 // The last time this TemplateURL was modified by a user, since creation. 108 // The last time this TemplateURL was modified by a user, since creation.
109 // 109 //
110 // NOTE: Like date_created above, this may be 0. 110 // NOTE: Like date_created above, this may be 0.
111 base::Time last_modified; 111 base::Time last_modified;
112 112
113 // Date when this TemplateURL was last visited.
114 //
115 // NOTE: This might be 0 if the TemplateURL has never been visited..
Peter Kasting 2016/12/01 07:38:24 Nit: Only a single trailing period
ltian 2016/12/01 10:02:58 Done.
116 base::Time last_visited;
117
113 // True if this TemplateURL was automatically created by the administrator via 118 // True if this TemplateURL was automatically created by the administrator via
114 // group policy. 119 // group policy.
115 bool created_by_policy; 120 bool created_by_policy;
116 121
117 // Number of times this TemplateURL has been explicitly used to load a URL. 122 // Number of times this TemplateURL has been explicitly used to load a URL.
118 // We don't increment this for uses as the "default search engine" since 123 // We don't increment this for uses as the "default search engine" since
119 // that's not really "explicit" usage and incrementing would result in pinning 124 // that's not really "explicit" usage and incrementing would result in pinning
120 // the user's default search engine(s) to the top of the list of searches on 125 // the user's default search engine(s) to the top of the list of searches on
121 // the New Tab page, de-emphasizing the omnibox as "where you go to search". 126 // the New Tab page, de-emphasizing the omnibox as "where you go to search".
122 int usage_count; 127 int usage_count;
(...skipping 15 matching lines...) Expand all
138 143
139 private: 144 private:
140 // Private so we can enforce using the setters and thus enforce that these 145 // Private so we can enforce using the setters and thus enforce that these
141 // fields are never empty. 146 // fields are never empty.
142 base::string16 short_name_; 147 base::string16 short_name_;
143 base::string16 keyword_; 148 base::string16 keyword_;
144 std::string url_; 149 std::string url_;
145 }; 150 };
146 151
147 #endif // COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_DATA_H_ 152 #endif // COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_DATA_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698