Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: components/search_engines/default_search_manager.cc

Issue 2498053002: Add field to monitor last visited time for each search engine (Closed)
Patch Set: Update Nit comment. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/search_engines/default_search_manager.h" 5 #include "components/search_engines/default_search_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 const char DefaultSearchManager::kInstantURLPostParams[] = 63 const char DefaultSearchManager::kInstantURLPostParams[] =
64 "instant_url_post_params"; 64 "instant_url_post_params";
65 const char DefaultSearchManager::kImageURLPostParams[] = 65 const char DefaultSearchManager::kImageURLPostParams[] =
66 "image_url_post_params"; 66 "image_url_post_params";
67 67
68 const char DefaultSearchManager::kSafeForAutoReplace[] = "safe_for_autoreplace"; 68 const char DefaultSearchManager::kSafeForAutoReplace[] = "safe_for_autoreplace";
69 const char DefaultSearchManager::kInputEncodings[] = "input_encodings"; 69 const char DefaultSearchManager::kInputEncodings[] = "input_encodings";
70 70
71 const char DefaultSearchManager::kDateCreated[] = "date_created"; 71 const char DefaultSearchManager::kDateCreated[] = "date_created";
72 const char DefaultSearchManager::kLastModified[] = "last_modified"; 72 const char DefaultSearchManager::kLastModified[] = "last_modified";
73 const char DefaultSearchManager::kLastVisited[] = "last_visited";
73 74
74 const char DefaultSearchManager::kUsageCount[] = "usage_count"; 75 const char DefaultSearchManager::kUsageCount[] = "usage_count";
75 const char DefaultSearchManager::kAlternateURLs[] = "alternate_urls"; 76 const char DefaultSearchManager::kAlternateURLs[] = "alternate_urls";
76 const char DefaultSearchManager::kSearchTermsReplacementKey[] = 77 const char DefaultSearchManager::kSearchTermsReplacementKey[] =
77 "search_terms_replacement_key"; 78 "search_terms_replacement_key";
78 const char DefaultSearchManager::kCreatedByPolicy[] = "created_by_policy"; 79 const char DefaultSearchManager::kCreatedByPolicy[] = "created_by_policy";
79 const char DefaultSearchManager::kDisabledByPolicy[] = "disabled_by_policy"; 80 const char DefaultSearchManager::kDisabledByPolicy[] = "disabled_by_policy";
80 81
81 DefaultSearchManager::DefaultSearchManager( 82 DefaultSearchManager::DefaultSearchManager(
82 PrefService* pref_service, 83 PrefService* pref_service,
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 } 155 }
155 156
156 void DefaultSearchManager::SetUserSelectedDefaultSearchEngine( 157 void DefaultSearchManager::SetUserSelectedDefaultSearchEngine(
157 const TemplateURLData& data) { 158 const TemplateURLData& data) {
158 if (!pref_service_) { 159 if (!pref_service_) {
159 prefs_default_search_.reset(new TemplateURLData(data)); 160 prefs_default_search_.reset(new TemplateURLData(data));
160 MergePrefsDataWithPrepopulated(); 161 MergePrefsDataWithPrepopulated();
161 NotifyObserver(); 162 NotifyObserver();
162 return; 163 return;
163 } 164 }
165
164 pref_service_->Set(kDefaultSearchProviderDataPrefName, 166 pref_service_->Set(kDefaultSearchProviderDataPrefName,
165 *TemplateURLDataToDictionary(data)); 167 *TemplateURLDataToDictionary(data));
166 } 168 }
167 169
168 void DefaultSearchManager::SetExtensionControlledDefaultSearchEngine( 170 void DefaultSearchManager::SetExtensionControlledDefaultSearchEngine(
169 const TemplateURLData& data) { 171 const TemplateURLData& data) {
170 extension_default_search_.reset(new TemplateURLData(data)); 172 extension_default_search_.reset(new TemplateURLData(data));
171 if (GetDefaultSearchEngineSource() == FROM_EXTENSION) 173 if (GetDefaultSearchEngineSource() == FROM_EXTENSION)
172 NotifyObserver(); 174 NotifyObserver();
173 } 175 }
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 227
226 if (!prefs_default_search_->safe_for_autoreplace) { 228 if (!prefs_default_search_->safe_for_autoreplace) {
227 engine->safe_for_autoreplace = false; 229 engine->safe_for_autoreplace = false;
228 engine->SetKeyword(prefs_default_search_->keyword()); 230 engine->SetKeyword(prefs_default_search_->keyword());
229 engine->SetShortName(prefs_default_search_->short_name()); 231 engine->SetShortName(prefs_default_search_->short_name());
230 } 232 }
231 engine->id = prefs_default_search_->id; 233 engine->id = prefs_default_search_->id;
232 engine->sync_guid = prefs_default_search_->sync_guid; 234 engine->sync_guid = prefs_default_search_->sync_guid;
233 engine->date_created = prefs_default_search_->date_created; 235 engine->date_created = prefs_default_search_->date_created;
234 engine->last_modified = prefs_default_search_->last_modified; 236 engine->last_modified = prefs_default_search_->last_modified;
237 engine->last_visited = prefs_default_search_->last_visited;
235 238
236 prefs_default_search_ = std::move(engine); 239 prefs_default_search_ = std::move(engine);
237 return; 240 return;
238 } 241 }
239 } 242 }
240 243
241 void DefaultSearchManager::LoadDefaultSearchEngineFromPrefs() { 244 void DefaultSearchManager::LoadDefaultSearchEngineFromPrefs() {
242 if (!pref_service_) 245 if (!pref_service_)
243 return; 246 return;
244 247
(...skipping 30 matching lines...) Expand all
275 MergePrefsDataWithPrepopulated(); 278 MergePrefsDataWithPrepopulated();
276 } 279 }
277 280
278 void DefaultSearchManager::NotifyObserver() { 281 void DefaultSearchManager::NotifyObserver() {
279 if (!change_observer_.is_null()) { 282 if (!change_observer_.is_null()) {
280 Source source = FROM_FALLBACK; 283 Source source = FROM_FALLBACK;
281 TemplateURLData* data = GetDefaultSearchEngine(&source); 284 TemplateURLData* data = GetDefaultSearchEngine(&source);
282 change_observer_.Run(data, source); 285 change_observer_.Run(data, source);
283 } 286 }
284 } 287 }
OLDNEW
« no previous file with comments | « components/search_engines/default_search_manager.h ('k') | components/search_engines/default_search_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698