Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: components/search_engines/template_url_data_util.cc

Issue 2498053002: Add field to monitor last visited time for each search engine (Closed)
Patch Set: Update Nit comment. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/search_engines/template_url_data_util.h" 5 #include "components/search_engines/template_url_data_util.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 &result->suggestions_url_post_params); 60 &result->suggestions_url_post_params);
61 dict.GetString(DefaultSearchManager::kInstantURLPostParams, 61 dict.GetString(DefaultSearchManager::kInstantURLPostParams,
62 &result->instant_url_post_params); 62 &result->instant_url_post_params);
63 dict.GetString(DefaultSearchManager::kImageURLPostParams, 63 dict.GetString(DefaultSearchManager::kImageURLPostParams,
64 &result->image_url_post_params); 64 &result->image_url_post_params);
65 dict.GetBoolean(DefaultSearchManager::kSafeForAutoReplace, 65 dict.GetBoolean(DefaultSearchManager::kSafeForAutoReplace,
66 &result->safe_for_autoreplace); 66 &result->safe_for_autoreplace);
67 67
68 std::string date_created_str; 68 std::string date_created_str;
69 std::string last_modified_str; 69 std::string last_modified_str;
70 std::string last_visited_str;
70 dict.GetString(DefaultSearchManager::kDateCreated, &date_created_str); 71 dict.GetString(DefaultSearchManager::kDateCreated, &date_created_str);
71 dict.GetString(DefaultSearchManager::kLastModified, &last_modified_str); 72 dict.GetString(DefaultSearchManager::kLastModified, &last_modified_str);
73 dict.GetString(DefaultSearchManager::kLastVisited, &last_visited_str);
72 74
73 int64_t date_created = 0; 75 int64_t date_created = 0;
74 if (base::StringToInt64(date_created_str, &date_created)) { 76 if (base::StringToInt64(date_created_str, &date_created))
75 result->date_created = base::Time::FromInternalValue(date_created); 77 result->date_created = base::Time::FromInternalValue(date_created);
76 }
77 78
78 int64_t last_modified = 0; 79 int64_t last_modified = 0;
79 if (base::StringToInt64(date_created_str, &last_modified)) { 80 if (base::StringToInt64(date_created_str, &last_modified))
80 result->last_modified = base::Time::FromInternalValue(last_modified); 81 result->last_modified = base::Time::FromInternalValue(last_modified);
81 } 82
83 int64_t last_visited = 0;
84 if (base::StringToInt64(last_visited_str, &last_visited))
85 result->last_visited = base::Time::FromInternalValue(last_visited);
82 86
83 dict.GetInteger(DefaultSearchManager::kUsageCount, &result->usage_count); 87 dict.GetInteger(DefaultSearchManager::kUsageCount, &result->usage_count);
84 88
85 const base::ListValue* alternate_urls = nullptr; 89 const base::ListValue* alternate_urls = nullptr;
86 if (dict.GetList(DefaultSearchManager::kAlternateURLs, &alternate_urls)) { 90 if (dict.GetList(DefaultSearchManager::kAlternateURLs, &alternate_urls)) {
87 for (const auto& it : *alternate_urls) { 91 for (const auto& it : *alternate_urls) {
88 std::string alternate_url; 92 std::string alternate_url;
89 if (it->GetAsString(&alternate_url)) 93 if (it->GetAsString(&alternate_url))
90 result->alternate_urls.push_back(std::move(alternate_url)); 94 result->alternate_urls.push_back(std::move(alternate_url));
91 } 95 }
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 data.image_url_post_params); 144 data.image_url_post_params);
141 145
142 url_dict->SetBoolean(DefaultSearchManager::kSafeForAutoReplace, 146 url_dict->SetBoolean(DefaultSearchManager::kSafeForAutoReplace,
143 data.safe_for_autoreplace); 147 data.safe_for_autoreplace);
144 148
145 url_dict->SetString(DefaultSearchManager::kDateCreated, 149 url_dict->SetString(DefaultSearchManager::kDateCreated,
146 base::Int64ToString(data.date_created.ToInternalValue())); 150 base::Int64ToString(data.date_created.ToInternalValue()));
147 url_dict->SetString( 151 url_dict->SetString(
148 DefaultSearchManager::kLastModified, 152 DefaultSearchManager::kLastModified,
149 base::Int64ToString(data.last_modified.ToInternalValue())); 153 base::Int64ToString(data.last_modified.ToInternalValue()));
154 url_dict->SetString(
155 DefaultSearchManager::kLastVisited,
156 base::Int64ToString(data.last_visited.ToInternalValue()));
150 url_dict->SetInteger(DefaultSearchManager::kUsageCount, data.usage_count); 157 url_dict->SetInteger(DefaultSearchManager::kUsageCount, data.usage_count);
151 158
152 auto alternate_urls = base::MakeUnique<base::ListValue>(); 159 auto alternate_urls = base::MakeUnique<base::ListValue>();
153 for (const auto& alternate_url : data.alternate_urls) 160 for (const auto& alternate_url : data.alternate_urls)
154 alternate_urls->AppendString(alternate_url); 161 alternate_urls->AppendString(alternate_url);
155 162
156 url_dict->Set(DefaultSearchManager::kAlternateURLs, 163 url_dict->Set(DefaultSearchManager::kAlternateURLs,
157 std::move(alternate_urls)); 164 std::move(alternate_urls));
158 165
159 auto encodings = base::MakeUnique<base::ListValue>(); 166 auto encodings = base::MakeUnique<base::ListValue>();
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 &search_terms_replacement_key); 235 &search_terms_replacement_key);
229 return base::MakeUnique<TemplateURLData>( 236 return base::MakeUnique<TemplateURLData>(
230 name, keyword, search_url, suggest_url, instant_url, image_url, 237 name, keyword, search_url, suggest_url, instant_url, image_url,
231 new_tab_url, contextual_search_url, search_url_post_params, 238 new_tab_url, contextual_search_url, search_url_post_params,
232 suggest_url_post_params, instant_url_post_params, image_url_post_params, 239 suggest_url_post_params, instant_url_post_params, image_url_post_params,
233 favicon_url, encoding, *alternate_urls, search_terms_replacement_key, 240 favicon_url, encoding, *alternate_urls, search_terms_replacement_key,
234 id); 241 id);
235 } 242 }
236 return std::unique_ptr<TemplateURLData>(); 243 return std::unique_ptr<TemplateURLData>();
237 } 244 }
OLDNEW
« no previous file with comments | « components/search_engines/template_url_data.cc ('k') | components/search_engines/template_url_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698