Add field to monitor last visited time for each search engine

components/search_engines/template_url_data_util.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/search_engines/template_url_data_util.h"
 
 #include <string>
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 49 matching lines @@
                  &result->suggestions_url_post_params);
   dict.GetString(DefaultSearchManager::kInstantURLPostParams,
                  &result->instant_url_post_params);
   dict.GetString(DefaultSearchManager::kImageURLPostParams,
                  &result->image_url_post_params);
   dict.GetBoolean(DefaultSearchManager::kSafeForAutoReplace,
                   &result->safe_for_autoreplace);
 
   std::string date_created_str;
   std::string last_modified_str;
+  std::string last_visited_str;
   dict.GetString(DefaultSearchManager::kDateCreated, &date_created_str);
   dict.GetString(DefaultSearchManager::kLastModified, &last_modified_str);
+  dict.GetString(DefaultSearchManager::kLastVisited, &last_visited_str);
 
   int64_t date_created = 0;
   if (base::StringToInt64(date_created_str, &date_created)) {
     result->date_created = base::Time::FromInternalValue(date_created);
   }
 
   int64_t last_modified = 0;
-  if (base::StringToInt64(date_created_str, &last_modified)) {
+  if (base::StringToInt64(last_modified_str, &last_modified)) {

[Peter Kasting, 2016/12/01 07:38:24]

Woah, this looks like it was a flat-out existing bug.  Can we add a test that
would have caught this?  (Maybe this fix + the test should be done in a separate
CL so it's easy to review and/or merge back?)

[ltian, 2016/12/01 10:02:58]

Yeah, this is the reason caused the problem that the last_modified resets back
once a TemplateURL is set as default. I will change it back and create a new CL
to fix this bug and add a test for it. 

     result->last_modified = base::Time::FromInternalValue(last_modified);
   }
 
+  int64_t last_visited = 0;
+  if (base::StringToInt64(last_visited_str, &last_visited)) {

[Peter Kasting, 2016/12/01 07:38:24]

Nit: This file is inconsistent about whether it uses {} or not on single-line
conditional bodies.  Here and in the two conditionals above we do, but in the
innermost two conditional just below we don't.

While here, I would make these consistent.  I'd probably omit {} as that's more
common within Chromium.

[ltian, 2016/12/01 10:02:58]

Done.

+    result->last_visited = base::Time::FromInternalValue(last_visited);
+  }
+
   dict.GetInteger(DefaultSearchManager::kUsageCount, &result->usage_count);
 
   const base::ListValue* alternate_urls = nullptr;
   if (dict.GetList(DefaultSearchManager::kAlternateURLs, &alternate_urls)) {
     for (const auto& it : *alternate_urls) {
       std::string alternate_url;
       if (it->GetAsString(&alternate_url))
         result->alternate_urls.push_back(std::move(alternate_url));
     }
   }
@@ skipping 47 matching lines @@
                       data.image_url_post_params);
 
   url_dict->SetBoolean(DefaultSearchManager::kSafeForAutoReplace,
                        data.safe_for_autoreplace);
 
   url_dict->SetString(DefaultSearchManager::kDateCreated,
                       base::Int64ToString(data.date_created.ToInternalValue()));
   url_dict->SetString(
       DefaultSearchManager::kLastModified,
       base::Int64ToString(data.last_modified.ToInternalValue()));
+  url_dict->SetString(
+      DefaultSearchManager::kLastVisited,
+      base::Int64ToString(data.last_visited.ToInternalValue()));
   url_dict->SetInteger(DefaultSearchManager::kUsageCount, data.usage_count);
 
   auto alternate_urls = base::MakeUnique<base::ListValue>();
   for (const auto& alternate_url : data.alternate_urls)
     alternate_urls->AppendString(alternate_url);
 
   url_dict->Set(DefaultSearchManager::kAlternateURLs,
                 std::move(alternate_urls));
 
   auto encodings = base::MakeUnique<base::ListValue>();
@@ skipping 68 matching lines @@
                      &search_terms_replacement_key);
     return base::MakeUnique<TemplateURLData>(
         name, keyword, search_url, suggest_url, instant_url, image_url,
         new_tab_url, contextual_search_url, search_url_post_params,
         suggest_url_post_params, instant_url_post_params, image_url_post_params,
         favicon_url, encoding, *alternate_urls, search_terms_replacement_key,
         id);
   }
   return std::unique_ptr<TemplateURLData>();
 }