Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: components/search_engines/keyword_table_unittest.cc

Issue 2498053002: Add field to monitor last visited time for each search engine (Closed)
Patch Set: Update Nit comment. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/search_engines/keyword_table.cc ('k') | components/search_engines/template_url.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 keyword.search_url_post_params = "ie=utf-8,oe=utf-8"; 52 keyword.search_url_post_params = "ie=utf-8,oe=utf-8";
53 keyword.image_url_post_params = "name=1,value=2"; 53 keyword.image_url_post_params = "name=1,value=2";
54 keyword.favicon_url = GURL("http://favicon.url/"); 54 keyword.favicon_url = GURL("http://favicon.url/");
55 keyword.originating_url = GURL("http://google.com/"); 55 keyword.originating_url = GURL("http://google.com/");
56 keyword.safe_for_autoreplace = true; 56 keyword.safe_for_autoreplace = true;
57 keyword.input_encodings.push_back("UTF-8"); 57 keyword.input_encodings.push_back("UTF-8");
58 keyword.input_encodings.push_back("UTF-16"); 58 keyword.input_encodings.push_back("UTF-16");
59 keyword.id = 1; 59 keyword.id = 1;
60 keyword.date_created = base::Time::UnixEpoch(); 60 keyword.date_created = base::Time::UnixEpoch();
61 keyword.last_modified = base::Time::UnixEpoch(); 61 keyword.last_modified = base::Time::UnixEpoch();
62 keyword.last_visited = base::Time::UnixEpoch();
62 keyword.created_by_policy = true; 63 keyword.created_by_policy = true;
63 keyword.usage_count = 32; 64 keyword.usage_count = 32;
64 keyword.prepopulate_id = 10; 65 keyword.prepopulate_id = 10;
65 keyword.sync_guid = "1234-5678-90AB-CDEF"; 66 keyword.sync_guid = "1234-5678-90AB-CDEF";
66 keyword.alternate_urls.push_back("a_url1"); 67 keyword.alternate_urls.push_back("a_url1");
67 keyword.alternate_urls.push_back("a_url2"); 68 keyword.alternate_urls.push_back("a_url2");
68 keyword.search_terms_replacement_key = "espv"; 69 keyword.search_terms_replacement_key = "espv";
69 AddKeyword(keyword); 70 AddKeyword(keyword);
70 return keyword; 71 return keyword;
71 } 72 }
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 EXPECT_EQ(keyword.originating_url, restored_keyword.originating_url); 126 EXPECT_EQ(keyword.originating_url, restored_keyword.originating_url);
126 EXPECT_EQ(keyword.safe_for_autoreplace, 127 EXPECT_EQ(keyword.safe_for_autoreplace,
127 restored_keyword.safe_for_autoreplace); 128 restored_keyword.safe_for_autoreplace);
128 EXPECT_EQ(keyword.input_encodings, restored_keyword.input_encodings); 129 EXPECT_EQ(keyword.input_encodings, restored_keyword.input_encodings);
129 EXPECT_EQ(keyword.id, restored_keyword.id); 130 EXPECT_EQ(keyword.id, restored_keyword.id);
130 // The database stores time only at the resolution of a second. 131 // The database stores time only at the resolution of a second.
131 EXPECT_EQ(keyword.date_created.ToTimeT(), 132 EXPECT_EQ(keyword.date_created.ToTimeT(),
132 restored_keyword.date_created.ToTimeT()); 133 restored_keyword.date_created.ToTimeT());
133 EXPECT_EQ(keyword.last_modified.ToTimeT(), 134 EXPECT_EQ(keyword.last_modified.ToTimeT(),
134 restored_keyword.last_modified.ToTimeT()); 135 restored_keyword.last_modified.ToTimeT());
136 EXPECT_EQ(keyword.last_visited.ToTimeT(),
137 restored_keyword.last_visited.ToTimeT());
135 EXPECT_EQ(keyword.created_by_policy, restored_keyword.created_by_policy); 138 EXPECT_EQ(keyword.created_by_policy, restored_keyword.created_by_policy);
136 EXPECT_EQ(keyword.usage_count, restored_keyword.usage_count); 139 EXPECT_EQ(keyword.usage_count, restored_keyword.usage_count);
137 EXPECT_EQ(keyword.prepopulate_id, restored_keyword.prepopulate_id); 140 EXPECT_EQ(keyword.prepopulate_id, restored_keyword.prepopulate_id);
138 141
139 RemoveKeyword(restored_keyword.id); 142 RemoveKeyword(restored_keyword.id);
140 143
141 EXPECT_EQ(0U, GetKeywords().size()); 144 EXPECT_EQ(0U, GetKeywords().size());
142 } 145 }
143 146
144 TEST_F(KeywordTableTest, KeywordMisc) { 147 TEST_F(KeywordTableTest, KeywordMisc) {
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 keyword.id = 2000; 245 keyword.id = 2000;
243 AddKeyword(keyword); 246 AddKeyword(keyword);
244 KeywordTable::Keywords keywords(GetKeywords()); 247 KeywordTable::Keywords keywords(GetKeywords());
245 EXPECT_EQ(1U, keywords.size()); 248 EXPECT_EQ(1U, keywords.size());
246 const TemplateURLData& keyword_from_database = keywords.front(); 249 const TemplateURLData& keyword_from_database = keywords.front();
247 EXPECT_EQ(keyword.id, keyword_from_database.id); 250 EXPECT_EQ(keyword.id, keyword_from_database.id);
248 EXPECT_EQ(ASCIIToUTF16("bogus name"), keyword_from_database.short_name()); 251 EXPECT_EQ(ASCIIToUTF16("bogus name"), keyword_from_database.short_name());
249 RemoveKeyword(keyword.id); 252 RemoveKeyword(keyword.id);
250 } 253 }
251 } 254 }
OLDNEW
« no previous file with comments | « components/search_engines/keyword_table.cc ('k') | components/search_engines/template_url.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698