components/sync/protocol/search_engine_specifics.proto - Issue 2498053002: Add field to monitor last visited time for each search engine

Side by Side Diff: components/sync/protocol/search_engine_specifics.proto

Issue 2498053002: Add field to monitor last visited time for each search engine (Closed)

Patch Set: Add unit test for last_visited field. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« components/search_engines/template_url_service.cc ('K') | « components/sync/protocol/proto_visitors.h ('k') | components/test/data/web_database/version_68.sql » ('j') | components/webdata/common/web_database.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // Sync protocol datatype extension for custom search engines.	5 // Sync protocol datatype extension for custom search engines.

6	6

7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change	7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change

8 // any fields in this file.	8 // any fields in this file.

9	9

10 syntax = "proto2";	10 syntax = "proto2";

(...skipping 60 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
71	71

72 // The following post_params are comma-separated lists used to specify the	72 // The following post_params are comma-separated lists used to specify the

73 // post parameters for the corresponding search URL.	73 // post parameters for the corresponding search URL.

74 optional string search_url_post_params = 22;	74 optional string search_url_post_params = 22;

75 optional string suggestions_url_post_params = 23;	75 optional string suggestions_url_post_params = 23;

76 optional string instant_url_post_params = 24;	76 optional string instant_url_post_params = 24;

77 optional string image_url_post_params = 25;	77 optional string image_url_post_params = 25;

78	78

79 // The parameterized URL for a search provider specified new tab page.	79 // The parameterized URL for a search provider specified new tab page.

80 optional string new_tab_url = 26;	80 optional string new_tab_url = 26;

	81

	82 // The date this search engine entry was last visited. A UTC timestamp with

	83 // units
	Peter Kasting 2016/11/21 03:35:08 Nit: Broken line wrapping This usually happens if Nit: Broken line wrapping This usually happens if git cl format reformats a comment that was too long. If you haven't already done so, consider modifying your editor of choice so the 80-column mark is clearly visible and you'll be unlikely to write comments that exceed it. ltian 2016/11/28 22:08:02 I know Java's maximum column size is 100 and C/C++ Show quoted text On 2016/11/21 03:35:08, Peter Kasting wrote: > Nit: Broken line wrapping > > This usually happens if git cl format reformats a comment that was too long. If > you haven't already done so, consider modifying your editor of choice so the > 80-column mark is clearly visible and you'll be unlikely to write comments that > exceed it. I know Java's maximum column size is 100 and C/C++ one is 80. But do you have any idea what are the maximum column sizes for the other types of files? I cannot find reference of them. Peter Kasting 2016/11/28 22:20:24 I don't know. I would assume 80 columns in the ab Show quoted text On 2016/11/28 22:08:02, ltian wrote: > On 2016/11/21 03:35:08, Peter Kasting wrote: > > Nit: Broken line wrapping > > > > This usually happens if git cl format reformats a comment that was too long. > If > > you haven't already done so, consider modifying your editor of choice so the > > 80-column mark is clearly visible and you'll be unlikely to write comments > that > > exceed it. > > I know Java's maximum column size is 100 and C/C++ one is 80. But do you have > any idea what are the maximum column sizes for the other types of files? I > cannot find reference of them. I don't know. I would assume 80 columns in the absence of other info.
	84 // in microseconds.

	85 optional int64 last_visited = 27;

81 }	86 }

OLD	NEW