Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 247283005: Update GPU command buffer auto formatting. (Closed)

Created:
6 years, 8 months ago by vmiura
Modified:
6 years, 7 months ago
Reviewers:
zmo, Zhenyao Mo, jbauman
CC:
chromium-reviews, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Update GPU command buffer auto formatting. Looks like clang-format rules changed. Updating to latest output of: ./gpu/command_buffer/build_gles2_cmd_buffer.py BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266999

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. Remove mojo/ change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4454 lines, -1972 lines) Patch
M gpu/command_buffer/client/client_context_state_impl_autogen.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 13 chunks +818 lines, -384 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 4 chunks +17 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 6 chunks +18 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 4 chunks +17 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 15 chunks +402 lines, -195 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 4 chunks +17 lines, -8 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 33 chunks +230 lines, -176 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +233 lines, -233 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 41 chunks +2463 lines, -851 lines 0 comments Download
M gpu/command_buffer/service/context_state_impl_autogen.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 7 chunks +21 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 25 chunks +75 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 6 chunks +139 lines, -69 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vmiura
PTAL
6 years, 8 months ago (2014-04-23 00:36:17 UTC) #1
vmiura
PTAL
6 years, 8 months ago (2014-04-23 00:36:47 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/247283005/diff/1/mojo/public/c/gles2/gles2_call_visitor_autogen.h File mojo/public/c/gles2/gles2_call_visitor_autogen.h (right): https://codereview.chromium.org/247283005/diff/1/mojo/public/c/gles2/gles2_call_visitor_autogen.h#newcode188 mojo/public/c/gles2/gles2_call_visitor_autogen.h:188: (GLsizei n, GLuint * renderbuffers), I had the same ...
6 years, 8 months ago (2014-04-23 19:59:07 UTC) #3
vmiura
On 2014/04/23 19:59:07, Zhenyao Mo wrote: > https://codereview.chromium.org/247283005/diff/1/mojo/public/c/gles2/gles2_call_visitor_autogen.h > File mojo/public/c/gles2/gles2_call_visitor_autogen.h (right): > > https://codereview.chromium.org/247283005/diff/1/mojo/public/c/gles2/gles2_call_visitor_autogen.h#newcode188 ...
6 years, 8 months ago (2014-04-23 20:07:01 UTC) #4
vmiura
The CQ bit was checked by vmiura@chromium.org
6 years, 7 months ago (2014-04-29 16:55:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmiura@chromium.org/247283005/20001
6 years, 7 months ago (2014-04-29 16:55:29 UTC) #6
vmiura
https://codereview.chromium.org/247283005/diff/1/mojo/public/c/gles2/gles2_call_visitor_autogen.h File mojo/public/c/gles2/gles2_call_visitor_autogen.h (right): https://codereview.chromium.org/247283005/diff/1/mojo/public/c/gles2/gles2_call_visitor_autogen.h#newcode188 mojo/public/c/gles2/gles2_call_visitor_autogen.h:188: (GLsizei n, GLuint * renderbuffers), On 2014/04/23 19:59:07, Zhenyao ...
6 years, 7 months ago (2014-04-29 16:58:59 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 00:07:20 UTC) #8
Message was sent while issue was closed. 
Change committed as 266999

Powered by Google App Engine
This is Rietveld 408576698