Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2465983002: Rename "paint invalidation rect" etc. to "visual rect". (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
chrishtr
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dmazzoni, dmazzoni+watch_chromium.org, dshwang, krit, dtseng+watch_chromium.org, eae+blinkwatch, f(malita), fs, gyuyoung2, haraken, jchaffraix+rendering, je_julie, jfernandez, kouhei+svg_chromium.org, leviw+renderwatch, nektarios, nektar+watch_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, rwlbuis, Stephen Chennney, svillar, szager+layoutwatch_chromium.org, yuzo+watch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename "paint invalidation rect" etc. to "visual rect". CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/697c5ef166bda977746e5ac516bca9a035837c8a Cr-Commit-Position: refs/heads/master@{#429178}

Patch Set 1 #

Patch Set 2 : - #

Total comments: 2

Patch Set 3 : - #

Patch Set 4 : Rebase #

Patch Set 5 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+549 lines, -643 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 4 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 8 chunks +26 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 6 chunks +28 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 2 chunks +13 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp View 17 chunks +73 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 2 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 3 chunks +19 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRootTest.cpp View 1 chunk +33 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h View 1 2 3 2 chunks +16 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 6 chunks +24 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/SpatialNavigation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp View 5 chunks +15 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/GridPainter.cpp View 3 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h View 2 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 1 2 3 4 10 chunks +35 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp View 6 chunks +43 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 4 chunks +11 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/README.md View 1 2 3 chunks +12 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGClipPainter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGClipPainter.cpp View 1 2 3 6 chunks +15 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGMaskPainter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGMaskPainter.cpp View 1 2 3 4 chunks +9 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGShapePainter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/SVGComputedStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 30 (18 generated)
Xianzhu
4 years, 1 month ago (2016-10-31 18:32:56 UTC) #6
chrishtr
Please also update core/paint/README.md. https://codereview.chromium.org/2465983002/diff/20001/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h File third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h (left): https://codereview.chromium.org/2465983002/diff/20001/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h#oldcode47 third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h:47: // https://bugs.webkit.org/show_bug.cgi?id=20400 Why is this ...
4 years, 1 month ago (2016-10-31 20:24:59 UTC) #10
Xianzhu
On 2016/10/31 20:24:59, chrishtr wrote: > Please also update core/paint/README.md. > Done. https://codereview.chromium.org/2465983002/diff/20001/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h File third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h ...
4 years, 1 month ago (2016-10-31 21:44:47 UTC) #11
chrishtr
lgtm
4 years, 1 month ago (2016-10-31 22:02:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465983002/40001
4 years, 1 month ago (2016-10-31 22:03:02 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/27644) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-10-31 22:07:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465983002/60001
4 years, 1 month ago (2016-10-31 22:26:16 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465983002/80001
4 years, 1 month ago (2016-11-01 22:00:26 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/172322)
4 years, 1 month ago (2016-11-02 00:46:49 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465983002/80001
4 years, 1 month ago (2016-11-02 00:48:09 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-02 01:28:22 UTC) #28
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 01:30:30 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/697c5ef166bda977746e5ac516bca9a035837c8a
Cr-Commit-Position: refs/heads/master@{#429178}

Powered by Google App Engine
This is Rietveld 408576698