Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h

Issue 2465983002: Rename "paint invalidation rect" etc. to "visual rect". (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h
diff --git a/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h b/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h
index a2f2e193e3745c4d08bd6c0e8883d50ee5ae66c5..05bd37194384bb12b73e97e2f4b287685ce69613 100644
--- a/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h
+++ b/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h
@@ -62,10 +62,9 @@ class CORE_EXPORT SVGLayoutSupport {
// Helper function determining whether overflow is hidden.
static bool isOverflowHidden(const LayoutObject*);
- // Calculates the paintInvalidationRect in combination with filter, clipper
- // and masker in local coordinates.
- static void intersectPaintInvalidationRectWithResources(const LayoutObject*,
- FloatRect&);
+ // Adjusts the visualRect in combination with filter, clipper and masker
+ // in local coordinates.
+ static void adjustVisualRectWithResources(const LayoutObject*, FloatRect&);
// Determine if the LayoutObject references a filter resource object.
static bool hasFilterResource(const LayoutObject&);
@@ -82,26 +81,25 @@ class CORE_EXPORT SVGLayoutSupport {
const FloatPoint& pointInParent,
FloatPoint& localPoint);
- static void computeContainerBoundingBoxes(
- const LayoutObject* container,
- FloatRect& objectBoundingBox,
- bool& objectBoundingBoxValid,
- FloatRect& strokeBoundingBox,
- FloatRect& paintInvalidationBoundingBox);
+ static void computeContainerBoundingBoxes(const LayoutObject* container,
+ FloatRect& objectBoundingBox,
+ bool& objectBoundingBoxValid,
+ FloatRect& strokeBoundingBox,
+ FloatRect& localVisualRect);
// Important functions used by nearly all SVG layoutObjects centralizing
- // coordinate transformations / paint invalidation rect calculations
- static FloatRect localOverflowRectForPaintInvalidation(const LayoutObject&);
- static LayoutRect clippedOverflowRectForPaintInvalidation(
+ // coordinate transformations / visual rect calculations
+ static FloatRect localVisualRect(const LayoutObject&);
+ static LayoutRect visualRectInAncestorSpace(
const LayoutObject&,
- const LayoutBoxModelObject& paintInvalidationContainer);
- static LayoutRect transformPaintInvalidationRect(const LayoutObject&,
- const AffineTransform&,
- const FloatRect&);
+ const LayoutBoxModelObject& ancestor);
+ static LayoutRect transformVisualRect(const LayoutObject&,
+ const AffineTransform&,
+ const FloatRect&);
static bool mapToVisualRectInAncestorSpace(
const LayoutObject&,
const LayoutBoxModelObject* ancestor,
- const FloatRect& localPaintInvalidationRect,
+ const FloatRect& localVisualRect,
LayoutRect& resultRect,
VisualRectFlags = DefaultVisualRectFlags);
static void mapLocalToAncestor(const LayoutObject*,

Powered by Google App Engine
This is Rietveld 408576698