Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2465983002: Rename "paint invalidation rect" etc. to "visual rect". (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 void PaintLayer::mapRectToPaintInvalidationBacking( 615 void PaintLayer::mapRectToPaintInvalidationBacking(
616 const LayoutObject& layoutObject, 616 const LayoutObject& layoutObject,
617 const LayoutBoxModelObject& paintInvalidationContainer, 617 const LayoutBoxModelObject& paintInvalidationContainer,
618 LayoutRect& rect) { 618 LayoutRect& rect) {
619 if (!paintInvalidationContainer.layer()->groupedMapping()) { 619 if (!paintInvalidationContainer.layer()->groupedMapping()) {
620 layoutObject.mapToVisualRectInAncestorSpace(&paintInvalidationContainer, 620 layoutObject.mapToVisualRectInAncestorSpace(&paintInvalidationContainer,
621 rect); 621 rect);
622 return; 622 return;
623 } 623 }
624 624
625 // This code adjusts the paint invalidation rectangle to be in the space of 625 // This code adjusts the visual rect to be in the space of the transformed
626 // the transformed ancestor of the grouped (i.e. squashed) layer. This is 626 // ancestor of the grouped (i.e. squashed) layer. This is because all layers
627 // because all layers that squash together need to issue paint invalidations 627 // that squash together need to issue paint invalidations w.r.t. a single
628 // w.r.t. a single container that is an ancestor of all of them, in order to 628 // container that is an ancestor of all of them, in order to properly take
629 // properly take into account any local transforms etc. 629 // into account any local transforms etc.
630 // FIXME: remove this special-case code that works around the paint 630 // FIXME: remove this special-case code that works around the paint
631 // invalidation code structure. 631 // invalidation code structure.
632 layoutObject.mapToVisualRectInAncestorSpace(&paintInvalidationContainer, 632 layoutObject.mapToVisualRectInAncestorSpace(&paintInvalidationContainer,
633 rect); 633 rect);
634 634
635 mapRectInPaintInvalidationContainerToBacking(paintInvalidationContainer, 635 mapRectInPaintInvalidationContainerToBacking(paintInvalidationContainer,
636 rect); 636 rect);
637 } 637 }
638 638
639 void PaintLayer::dirtyVisibleContentStatus() { 639 void PaintLayer::dirtyVisibleContentStatus() {
(...skipping 2626 matching lines...) Expand 10 before | Expand all | Expand 10 after
3266 } 3266 }
3267 3267
3268 void showLayerTree(const blink::LayoutObject* layoutObject) { 3268 void showLayerTree(const blink::LayoutObject* layoutObject) {
3269 if (!layoutObject) { 3269 if (!layoutObject) {
3270 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n"); 3270 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
3271 return; 3271 return;
3272 } 3272 }
3273 showLayerTree(layoutObject->enclosingLayer()); 3273 showLayerTree(layoutObject->enclosingLayer());
3274 } 3274 }
3275 #endif 3275 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698