Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: third_party/WebKit/Source/core/paint/README.md

Issue 2465983002: Rename "paint invalidation rect" etc. to "visual rect". (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/README.md
diff --git a/third_party/WebKit/Source/core/paint/README.md b/third_party/WebKit/Source/core/paint/README.md
index e0066f66536c76d42b57abbe4d48c6c942ba0021..1fdc4b1416e774897aa154885ea886c3d847e991 100644
--- a/third_party/WebKit/Source/core/paint/README.md
+++ b/third_party/WebKit/Source/core/paint/README.md
@@ -87,6 +87,9 @@ treated in different ways during painting:
* Paint invalidation container: the nearest object on the compositing container
chain which is composited.
+* Visual rect: the bounding box of all pixels that will be painted by a
+ display item client.
+
## Paint invalidation
Paint invalidation marks anything that need to be painted differently from the original
@@ -103,9 +106,12 @@ if needed by style change, layout change, compositing change, etc. In paint inva
we traverse the layout tree in pre-order, crossing frame boundaries, for marked subtrees
and objects and send the following information to `GraphicsLayer`s and `PaintController`s:
-* paint invalidation rects: must cover all areas that will generete different pixels.
-* invalidated display item clients: must invalidate all display item clients that will
- generate different display items.
+* invalidated display item clients: must invalidate all display item clients
+ that will generate different display items.
+
+* paint invalidation rects: must cover all areas that will generate different
+ pixels. They are generated based on visual rects of invalidated display item
+ clients.
#### `PaintInvalidationState`
@@ -142,8 +148,9 @@ we will fall back to slow-path using `LayoutObject::localToAncestorPoint()` or
causing we can't simply accumulate paint offset for mapping a local rect to paint invalidation
container;
-* An object has has filter or reflection, which needs to expand paint invalidation rect
- for descendants, because currently we don't include and reflection extents into visual overflow;
+* An object has has filter (including filter induced by reflection), which
+ needs to expand visual rect for descendants, because currently we don't
+ include and filter extents into visual overflow;
* For a fixed-position object we calculate its offset using `LayoutObject::localToAncestorPoint()`,
but map for its descendants in fast-path if no other things prevent us from doing this;

Powered by Google App Engine
This is Rietveld 408576698