third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp - Issue 2465983002: Rename "paint invalidation rect" etc. to "visual rect".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2465983002: Rename "paint invalidation rect" etc. to "visual rect". (Closed)

Patch Set: - Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp ('k') | third_party/WebKit/Source/core/paint/README.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

index e564d06dddeee4741123a7214405e3f6cc125b4d..727d9ca9587bdd5ea51760d2a7baa65c5287c774 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

@@ -92,8 +92,7 @@ class PaintPropertyTreeBuilderTest

slopFactor) \

do { \

GeometryMapper geometryMapper; \

- LayoutRect source( \

- (sourceLayoutObject)->localOverflowRectForPaintInvalidation()); \

+ LayoutRect source((sourceLayoutObject)->localVisualRect()); \

source.moveBy((sourceLayoutObject) \

->paintProperties() \

->localBorderBoxProperties() \

@@ -116,8 +115,7 @@ class PaintPropertyTreeBuilderTest

if (slopFactor == LayoutUnit::max()) \

break; \

- LayoutRect slowPathRect = \

- (sourceLayoutObject)->localOverflowRectForPaintInvalidation(); \

+ LayoutRect slowPathRect = (sourceLayoutObject)->localVisualRect(); \

(sourceLayoutObject) \

->mapToVisualRectInAncestorSpace(ancestorLayoutObject, slowPathRect); \

if (slopFactor) { \