Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp

Issue 2465983002: Rename "paint invalidation rect" etc. to "visual rect". (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp b/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
index 2e1c700fab6d95e1ef05905cc46ff442232bf319..5785e1c943504816957589cb57777c94fa7c4fa9 100644
--- a/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
+++ b/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
@@ -125,8 +125,7 @@ TEST_F(BoxPaintInvalidatorTest, SubpixelChangeWithoutVisualRectChange) {
Element* target = document().getElementById("target");
LayoutObject* targetObject = target->layoutObject();
- EXPECT_EQ(LayoutRect(0, 0, 70, 140),
- targetObject->previousPaintInvalidationRect());
+ EXPECT_EQ(LayoutRect(0, 0, 70, 140), targetObject->previousVisualRect());
// Should do full invalidation if new geometry has subpixels even if the paint
// invalidation rect doesn't change.
@@ -134,8 +133,7 @@ TEST_F(BoxPaintInvalidatorTest, SubpixelChangeWithoutVisualRectChange) {
target->setAttribute(HTMLNames::styleAttr,
"margin-top: 0.6px; width: 50px; height: 99.3px");
document().view()->updateAllLifecyclePhases();
- EXPECT_EQ(LayoutRect(0, 0, 70, 140),
- targetObject->previousPaintInvalidationRect());
+ EXPECT_EQ(LayoutRect(0, 0, 70, 140), targetObject->previousVisualRect());
const auto* rasterInvalidations =
&getRasterInvalidationTracking()->trackedRasterInvalidations;
EXPECT_EQ(1u, rasterInvalidations->size());
@@ -147,8 +145,7 @@ TEST_F(BoxPaintInvalidatorTest, SubpixelChangeWithoutVisualRectChange) {
target->setAttribute(HTMLNames::styleAttr,
"margin-top: 0.6px; width: 49.3px; height: 98.5px");
document().view()->updateAllLifecyclePhases();
- EXPECT_EQ(LayoutRect(0, 0, 70, 140),
- targetObject->previousPaintInvalidationRect());
+ EXPECT_EQ(LayoutRect(0, 0, 70, 140), targetObject->previousVisualRect());
rasterInvalidations =
&getRasterInvalidationTracking()->trackedRasterInvalidations;
EXPECT_EQ(1u, rasterInvalidations->size());
« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp ('k') | third_party/WebKit/Source/core/paint/GridPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698