Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h

Issue 2465983002: Rename "paint invalidation rect" etc. to "visual rect". (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
3 * Copyright (C) 2009 Google, Inc. 3 * Copyright (C) 2009 Google, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 24 matching lines...) Expand all
35 ~LayoutSVGGradientStop() override; 35 ~LayoutSVGGradientStop() override;
36 36
37 const char* name() const override { return "LayoutSVGGradientStop"; } 37 const char* name() const override { return "LayoutSVGGradientStop"; }
38 bool isOfType(LayoutObjectType type) const override { 38 bool isOfType(LayoutObjectType type) const override {
39 return type == LayoutObjectSVG || type == LayoutObjectSVGGradientStop || 39 return type == LayoutObjectSVG || type == LayoutObjectSVGGradientStop ||
40 LayoutObject::isOfType(type); 40 LayoutObject::isOfType(type);
41 } 41 }
42 42
43 void layout() override; 43 void layout() override;
44 44
45 // This overrides are needed to prevent ASSERTs on <svg><stop /></svg> 45 LayoutRect localVisualRect() const override { return LayoutRect(); }
46 // LayoutObject's default implementations ASSERT_NOT_REACHED()
47 // https://bugs.webkit.org/show_bug.cgi?id=20400
chrishtr 2016/10/31 20:24:59 Why is this comment no longer applicable?
Xianzhu 2016/10/31 21:44:47 Updated.
48 LayoutRect localOverflowRectForPaintInvalidation() const override {
49 return LayoutRect();
50 }
51 FloatRect objectBoundingBox() const override { return FloatRect(); } 46 FloatRect objectBoundingBox() const override { return FloatRect(); }
52 FloatRect strokeBoundingBox() const override { return FloatRect(); } 47 FloatRect strokeBoundingBox() const override { return FloatRect(); }
53 FloatRect paintInvalidationRectInLocalSVGCoordinates() const override { 48 FloatRect visualRectInLocalSVGCoordinates() const override {
54 return FloatRect(); 49 return FloatRect();
55 } 50 }
56 FloatRect localBoundingBoxRectForAccessibility() const final { 51 FloatRect localBoundingBoxRectForAccessibility() const final {
57 return FloatRect(); 52 return FloatRect();
58 } 53 }
59 54
60 protected: 55 protected:
61 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override; 56 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override;
62 57
63 private: 58 private:
64 SVGGradientElement* gradientElement() const; 59 SVGGradientElement* gradientElement() const;
65 }; 60 };
66 61
67 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGGradientStop, isSVGGradientStop()); 62 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGGradientStop, isSVGGradientStop());
68 63
69 } // namespace blink 64 } // namespace blink
70 65
71 #endif // LayoutSVGGradientStop_h 66 #endif // LayoutSVGGradientStop_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698