Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h

Issue 2465983002: Rename "paint invalidation rect" etc. to "visual rect". (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h
index 8960719f12ddaf52ab5fbff5da8fd5705ca8cd15..a89b36c10f36f3efd59cdb320208443fc74fd2f5 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h
@@ -42,15 +42,12 @@ class LayoutSVGGradientStop final : public LayoutObject {
void layout() override;
- // This overrides are needed to prevent ASSERTs on <svg><stop /></svg>
- // LayoutObject's default implementations ASSERT_NOT_REACHED()
- // https://bugs.webkit.org/show_bug.cgi?id=20400
- LayoutRect localOverflowRectForPaintInvalidation() const override {
- return LayoutRect();
- }
+ // These overrides are needed to prevent NOTREACHED on <svg><stop /></svg> in
+ // LayoutObject's default implementations.
+ LayoutRect localVisualRect() const override { return LayoutRect(); }
FloatRect objectBoundingBox() const override { return FloatRect(); }
FloatRect strokeBoundingBox() const override { return FloatRect(); }
- FloatRect paintInvalidationRectInLocalSVGCoordinates() const override {
+ FloatRect visualRectInLocalSVGCoordinates() const override {
return FloatRect();
}
FloatRect localBoundingBoxRectForAccessibility() const final {

Powered by Google App Engine
This is Rietveld 408576698