Don't wrap roots in Handle just to dereference immediately.

Don't wrap roots in Handle just to dereference immediately.

R=adamk@chromium.org
BUG=

Committed: https://crrev.com/d5de8f0d11ff8b52c71aee8064db429142ca9aad
Cr-Commit-Position: refs/heads/master@{#40584}

[neis, 2016-10-25 14:40:34]

Not sure it's worth it, let me know what you think.

[adamk, 2016-10-25 14:43:32]

I like it, every callsite reads better to me, lgtm (but I'm not in all the right
owners files)

[neis, 2016-10-25 14:46:33]

Description was changed from

==========
Don't create a handle just to throw it away when accessing roots.

R=adamk@chromium.org
BUG=
==========

to

==========
Don't create a handle just to throw it away when accessing roots.

R=adamk@chromium.org
BUG=
==========

[neis, 2016-10-25 14:46:33]

neis@chromium.org changed reviewers:
+ ahaas@chromium.org, bmeurer@chromium.org, yangguo@chromium.org

[neis, 2016-10-25 14:46:45]

On 2016/10/25 14:43:32, adamk wrote:
> I like it, every callsite reads better to me, lgtm (but I'm not in all the
right
> owners files)

+morepeople

[ahaas, 2016-10-25 14:48:18]

wasm lgtm

[Benedikt Meurer, 2016-10-25 16:55:20]

Technically we only wrap the root location into a Handle, we don't "create a
handle" in the sense of adding an entry to the handle list. Anyways, this is
LGTM :-)

[Yang, 2016-10-25 18:10:31]

On 2016/10/25 16:55:20, Benedikt Meurer wrote:
> Technically we only wrap the root location into a Handle, we don't "create a
> handle" in the sense of adding an entry to the handle list. Anyways, this is
> LGTM :-)

yeah I was about to say. factory handles are not handles on the stack. They are
just indirections casted to handles. But lgtm anyways.

[neis, 2016-10-26 09:26:36]

Description was changed from

==========
Don't create a handle just to throw it away when accessing roots.

R=adamk@chromium.org
BUG=
==========

to

==========
Don't wrap roots in Handle just to dereference immediately.

R=adamk@chromium.org
BUG=
==========

[neis, 2016-10-26 09:27:08]

On 2016/10/25 18:10:31, Yang wrote:
> On 2016/10/25 16:55:20, Benedikt Meurer wrote:
> > Technically we only wrap the root location into a Handle, we don't "create a
> > handle" in the sense of adding an entry to the handle list. Anyways, this is
> > LGTM :-)
> 
> yeah I was about to say. factory handles are not handles on the stack. They
are
> just indirections casted to handles. But lgtm anyways.

Thanks for the clarifications.

[neis, 2016-10-26 09:27:38]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-10-26 09:27:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 11:22:17]

Description was changed from

==========
Don't wrap roots in Handle just to dereference immediately.

R=adamk@chromium.org
BUG=
==========

to

==========
Don't wrap roots in Handle just to dereference immediately.

R=adamk@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-10-26 11:22:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:13:38]

Description was changed from

==========
Don't wrap roots in Handle just to dereference immediately.

R=adamk@chromium.org
BUG=
==========

to

==========
Don't wrap roots in Handle just to dereference immediately.

R=adamk@chromium.org
BUG=

Committed: https://crrev.com/d5de8f0d11ff8b52c71aee8064db429142ca9aad
Cr-Commit-Position: refs/heads/master@{#40584}
==========

[commit-bot: I haz the power, 2016-11-17 22:13:39]

Patchset 1 (id:??) landed as
https://crrev.com/d5de8f0d11ff8b52c71aee8064db429142ca9aad
Cr-Commit-Position: refs/heads/master@{#40584}