src/frames.cc - Issue 2452543003: Don't wrap roots in Handle just to dereference immediately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.cc

Issue 2452543003: Don't wrap roots in Handle just to dereference immediately. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.cc

diff --git a/src/frames.cc b/src/frames.cc

index e847a698a8e010db67143a4b352880be0e9a6b40..a9e696ba4fc36798bdbdef5fdc30ef64e274a89b 100644

--- a/src/frames.cc

+++ b/src/frames.cc

@@ -1494,7 +1494,7 @@ Address WasmFrame::GetCallerStackPointer() const {

Object* WasmFrame::wasm_instance() const {

Object* ret = wasm::GetOwningWasmInstance(LookupCode());

- if (ret == nullptr) ret = *(isolate()->factory()->undefined_value());

+ if (ret == nullptr) ret = isolate()->heap()->undefined_value();

return ret;

}

« no previous file with comments | « src/builtins/builtins-string.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »