src/runtime/runtime-i18n.cc - Issue 2452543003: Don't wrap roots in Handle just to dereference immediately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-i18n.cc

Issue 2452543003: Don't wrap roots in Handle just to dereference immediately. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-i18n.cc

diff --git a/src/runtime/runtime-i18n.cc b/src/runtime/runtime-i18n.cc

index b4f2e929e31933910c0abea57f2045ad4d279f4e..684699edf1837773e382ecc830db65e2e9c0f967 100644

--- a/src/runtime/runtime-i18n.cc

+++ b/src/runtime/runtime-i18n.cc

@@ -926,7 +926,7 @@ RUNTIME_FUNCTION(Runtime_BreakIteratorBreakType) {

if (status >= UBRK_WORD_NONE && status < UBRK_WORD_NONE_LIMIT) {

return *isolate->factory()->NewStringFromStaticChars("none");

} else if (status >= UBRK_WORD_NUMBER && status < UBRK_WORD_NUMBER_LIMIT) {

- return *isolate->factory()->number_string();

+ return isolate->heap()->number_string();

} else if (status >= UBRK_WORD_LETTER && status < UBRK_WORD_LETTER_LIMIT) {

return *isolate->factory()->NewStringFromStaticChars("letter");

} else if (status >= UBRK_WORD_KANA && status < UBRK_WORD_KANA_LIMIT) {

« no previous file with comments | « src/runtime/runtime-debug.cc ('k') | src/snapshot/code-serializer.cc » ('j') | no next file with comments »