Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: src/objects-inl.h

Issue 2452543003: Don't wrap roots in Handle just to dereference immediately. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/messages.cc ('k') | src/profiler/heap-snapshot-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 7849 matching lines...) Expand 10 before | Expand all | Expand 10 after
7860 } 7860 }
7861 7861
7862 7862
7863 uint32_t UnseededNumberDictionaryShape::HashForObject(uint32_t key, 7863 uint32_t UnseededNumberDictionaryShape::HashForObject(uint32_t key,
7864 Object* other) { 7864 Object* other) {
7865 DCHECK(other->IsNumber()); 7865 DCHECK(other->IsNumber());
7866 return ComputeIntegerHash(static_cast<uint32_t>(other->Number()), 0); 7866 return ComputeIntegerHash(static_cast<uint32_t>(other->Number()), 0);
7867 } 7867 }
7868 7868
7869 Map* UnseededNumberDictionaryShape::GetMap(Isolate* isolate) { 7869 Map* UnseededNumberDictionaryShape::GetMap(Isolate* isolate) {
7870 return *isolate->factory()->unseeded_number_dictionary_map(); 7870 return isolate->heap()->unseeded_number_dictionary_map();
7871 } 7871 }
7872 7872
7873 uint32_t SeededNumberDictionaryShape::SeededHash(uint32_t key, uint32_t seed) { 7873 uint32_t SeededNumberDictionaryShape::SeededHash(uint32_t key, uint32_t seed) {
7874 return ComputeIntegerHash(key, seed); 7874 return ComputeIntegerHash(key, seed);
7875 } 7875 }
7876 7876
7877 7877
7878 uint32_t SeededNumberDictionaryShape::SeededHashForObject(uint32_t key, 7878 uint32_t SeededNumberDictionaryShape::SeededHashForObject(uint32_t key,
7879 uint32_t seed, 7879 uint32_t seed,
7880 Object* other) { 7880 Object* other) {
(...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after
8415 #undef WRITE_INT64_FIELD 8415 #undef WRITE_INT64_FIELD
8416 #undef READ_BYTE_FIELD 8416 #undef READ_BYTE_FIELD
8417 #undef WRITE_BYTE_FIELD 8417 #undef WRITE_BYTE_FIELD
8418 #undef NOBARRIER_READ_BYTE_FIELD 8418 #undef NOBARRIER_READ_BYTE_FIELD
8419 #undef NOBARRIER_WRITE_BYTE_FIELD 8419 #undef NOBARRIER_WRITE_BYTE_FIELD
8420 8420
8421 } // namespace internal 8421 } // namespace internal
8422 } // namespace v8 8422 } // namespace v8
8423 8423
8424 #endif // V8_OBJECTS_INL_H_ 8424 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/messages.cc ('k') | src/profiler/heap-snapshot-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698