src/profiler/heap-snapshot-generator.cc - Issue 2452543003: Don't wrap roots in Handle just to dereference immediately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/heap-snapshot-generator.cc

Issue 2452543003: Don't wrap roots in Handle just to dereference immediately. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profiler/heap-snapshot-generator.cc

diff --git a/src/profiler/heap-snapshot-generator.cc b/src/profiler/heap-snapshot-generator.cc

index d0fa2e4c1b5f053f1f5a28c6f9788d9ee43fc7dc..2fd682e567945f989edb32fe6dce95fd63fee81a 100644

--- a/src/profiler/heap-snapshot-generator.cc

+++ b/src/profiler/heap-snapshot-generator.cc

@@ -1312,7 +1312,7 @@ void V8HeapExplorer::ExtractSharedFunctionInfoReferences(

HeapObject* obj = shared;

String* shared_name = shared->DebugName();

const char* name = NULL;

- if (shared_name != *heap_->isolate()->factory()->empty_string()) {

+ if (shared_name != heap_->empty_string()) {

name = names_->GetName(shared_name);

TagObject(shared->code(), names_->GetFormatted("(code for %s)", name));

} else {

« no previous file with comments | « src/objects-inl.h ('k') | src/regexp/jsregexp.cc » ('j') | no next file with comments »