src/bootstrapper.cc - Issue 2452543003: Don't wrap roots in Handle just to dereference immediately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 2452543003: Don't wrap roots in Handle just to dereference immediately. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index 6ebc5b57350792df558f704871d3007e5a749332..e90c2caa2b496f66929ce41d974a7f435b14020d 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -4542,7 +4542,7 @@ Genesis::Genesis(Isolate* isolate,

factory()->ReinitializeJSGlobalProxy(global_proxy, global_proxy_function);

// HookUpGlobalProxy.

- global_proxy->set_native_context(*factory()->null_value());

+ global_proxy->set_native_context(heap()->null_value());

// DetachGlobal.

JSObject::ForceSetPrototype(global_proxy, factory()->null_value());

« no previous file with comments | « src/ast/scopeinfo.cc ('k') | src/builtins/builtins-error.cc » ('j') | no next file with comments »