src/builtins/builtins-error.cc - Issue 2452543003: Don't wrap roots in Handle just to dereference immediately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-error.cc

Issue 2452543003: Don't wrap roots in Handle just to dereference immediately. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-error.cc

diff --git a/src/builtins/builtins-error.cc b/src/builtins/builtins-error.cc

index 3f2375ea6d8f4e93158df89b438407516c4c7783..24ae56bd06134e65a11be8f456372817d8bcd846 100644

--- a/src/builtins/builtins-error.cc

+++ b/src/builtins/builtins-error.cc

@@ -55,7 +55,7 @@ BUILTIN(ErrorCaptureStackTrace) {

Handle<Object> stack_trace =

isolate->CaptureSimpleStackTrace(object, mode, caller);

- if (!stack_trace->IsJSArray()) return *isolate->factory()->undefined_value();

+ if (!stack_trace->IsJSArray()) return isolate->heap()->undefined_value();

Handle<Object> formatted_stack_trace;

ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

« no previous file with comments | « src/bootstrapper.cc ('k') | src/builtins/builtins-math.cc » ('j') | no next file with comments »