src/runtime/runtime-debug.cc - Issue 2452543003: Don't wrap roots in Handle just to dereference immediately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-debug.cc

Issue 2452543003: Don't wrap roots in Handle just to dereference immediately. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-debug.cc

diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc

index 8e1abf249580e12171b84f1e4158734b693177af..d324916f972498bf418d8b41307b0938bd3ce8bf 100644

--- a/src/runtime/runtime-debug.cc

+++ b/src/runtime/runtime-debug.cc

@@ -948,7 +948,7 @@ RUNTIME_FUNCTION(Runtime_GetGeneratorScopeDetails) {

DCHECK(args.length() == 2);

if (!args[0]->IsJSGeneratorObject()) {

- return *isolate->factory()->undefined_value();

+ return isolate->heap()->undefined_value();

}

// Check arguments.

« no previous file with comments | « src/regexp/jsregexp.cc ('k') | src/runtime/runtime-i18n.cc » ('j') | no next file with comments »