src/builtins/builtins-math.cc - Issue 2452543003: Don't wrap roots in Handle just to dereference immediately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-math.cc

Issue 2452543003: Don't wrap roots in Handle just to dereference immediately. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-math.cc

diff --git a/src/builtins/builtins-math.cc b/src/builtins/builtins-math.cc

index ee531e4299e9e489c2e2d2348c109a209fa2737a..f4961ca8365ca1e16b8d13b536c938e26c536ae4 100644

--- a/src/builtins/builtins-math.cc

+++ b/src/builtins/builtins-math.cc

@@ -341,7 +341,7 @@ BUILTIN(MathHypot) {

}

if (one_arg_is_nan) {

- return *isolate->factory()->nan_value();

+ return isolate->heap()->nan_value();

}

if (max == 0) {

« no previous file with comments | « src/builtins/builtins-error.cc ('k') | src/builtins/builtins-string.cc » ('j') | no next file with comments »