Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos

Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos

BUG=581865
Committed: https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84
Cr-Commit-Position: refs/heads/master@{#425174}

[dcheng, 2016-10-13 17:42:08]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 17:42:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-13 17:43:26]

dcheng@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2016-10-13 17:57:16]

https://codereview.chromium.org/2418833003/diff/1/chrome/browser/chromeos/fil...
File chrome/browser/chromeos/file_manager/file_browser_handlers.cc (right):

https://codereview.chromium.org/2418833003/diff/1/chrome/browser/chromeos/fil...
chrome/browser/chromeos/file_manager/file_browser_handlers.cc:404:
file_entries->Append(std::move(file_def));
uh... file_def looks like it's still getting used after this. you need to move
this line to the end of the for body, right?

[commit-bot: I haz the power, 2016-10-13 18:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 18:50:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-10-13 19:42:46]

https://codereview.chromium.org/2418833003/diff/1/chrome/browser/chromeos/fil...
File chrome/browser/chromeos/file_manager/file_browser_handlers.cc (right):

https://codereview.chromium.org/2418833003/diff/1/chrome/browser/chromeos/fil...
chrome/browser/chromeos/file_manager/file_browser_handlers.cc:404:
file_entries->Append(std::move(file_def));
On 2016/10/13 17:57:16, Daniel Erat wrote:
> uh... file_def looks like it's still getting used after this. you need to move
> this line to the end of the for body, right?

Doh, I missed this one. Done.

[Daniel Erat, 2016-10-13 20:36:31]

thanks, lgtm

[dcheng, 2016-10-13 21:17:59]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-10-13 21:18:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 21:49:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 21:53:44]

Description was changed from

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/chromeos

BUG=581865
==========

to

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/chromeos

BUG=581865

Committed: https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84
Cr-Commit-Position: refs/heads/master@{#425174}
==========

[commit-bot: I haz the power, 2016-10-13 21:53:45]

Patchset 2 (id:??) landed as
https://crrev.com/518db73d1cbd212aabe93be8c150f3fe14e65f84
Cr-Commit-Position: refs/heads/master@{#425174}