Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc

Issue 2418833003: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos (Closed)
Patch Set: use-after-move Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
diff --git a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
index 19199db5da930d04e3016d0881267b32c197b2d8..9e976aed66d5a38d2f680f02219ecab9d9354bae 100644
--- a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
+++ b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
@@ -5,8 +5,10 @@
#include "chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.h"
#include <string>
+#include <utility>
#include "base/files/file_path.h"
+#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/strings/string16.h"
#include "base/values.h"
@@ -434,12 +436,12 @@ TEST(DeviceLocalAccountManagementPolicyProviderTest, PublicSession) {
// Verify that a platform app with socket dictionary permission can be
// installed.
{
- base::DictionaryValue* const socket = new base::DictionaryValue();
+ auto socket = base::MakeUnique<base::DictionaryValue>();
base::ListValue* const tcp_list = new base::ListValue();
tcp_list->AppendString("tcp-connect");
socket->Set("socket", tcp_list);
base::ListValue* const permissions = new base::ListValue();
- permissions->Append(socket);
+ permissions->Append(std::move(socket));
base::DictionaryValue values;
values.Set(extensions::manifest_keys::kPermissions, permissions);
@@ -457,12 +459,12 @@ TEST(DeviceLocalAccountManagementPolicyProviderTest, PublicSession) {
// Verify that a platform app with unknown dictionary permission cannot be
// installed.
{
- base::DictionaryValue* const socket = new base::DictionaryValue();
+ auto socket = base::MakeUnique<base::DictionaryValue>();
base::ListValue* const tcp_list = new base::ListValue();
tcp_list->AppendString("unknown_value");
socket->Set("unknown_key", tcp_list);
base::ListValue* const permissions = new base::ListValue();
- permissions->Append(socket);
+ permissions->Append(std::move(socket));
base::DictionaryValue values;
values.Set(extensions::manifest_keys::kPermissions, permissions);
« no previous file with comments | « chrome/browser/chromeos/arc/arc_policy_bridge.cc ('k') | chrome/browser/chromeos/extensions/wallpaper_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698