Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3409)

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc

Issue 2418833003: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos (Closed)
Patch Set: use-after-move Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc b/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
index 25d4048f5eee131147eac2f5dc4cba731bc71699..5acd7849c37344e53284c19fd82d2a2177107932 100644
--- a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
+++ b/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
@@ -4,9 +4,12 @@
#include "chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h"
+#include <utility>
+
#include "ash/common/shelf/wm_shelf.h"
#include "ash/common/wallpaper/wallpaper_controller.h"
#include "ash/common/wm_shell.h"
+#include "base/memory/ptr_util.h"
#include "base/rand_util.h"
#include "base/values.h"
#include "chrome/browser/chromeos/camera_detector.h"
@@ -538,8 +541,7 @@ void SupervisedUserCreationScreen::OnGetSupervisedUsers(
static_cast<base::DictionaryValue*>(it.value().DeepCopy());
// Copy that would be passed to WebUI. It has some extra values for
// displaying, but does not contain sensitive data, such as master password.
- base::DictionaryValue* ui_copy =
- static_cast<base::DictionaryValue*>(new base::DictionaryValue());
+ auto ui_copy = base::MakeUnique<base::DictionaryValue>();
int avatar_index = SupervisedUserCreationController::kDummyAvatarIndex;
std::string chromeos_avatar;
@@ -590,7 +592,7 @@ void SupervisedUserCreationScreen::OnGetSupervisedUsers(
ui_copy->SetString("id", it.key());
existing_users_->Set(it.key(), local_copy);
- ui_users->Append(ui_copy);
+ ui_users->Append(std::move(ui_copy));
}
actor_->ShowExistingSupervisedUsers(ui_users.get());
}

Powered by Google App Engine
This is Rietveld 408576698