chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc - Issue 2418833003: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

Issue 2418833003: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos (Closed)

Patch Set: use-after-move Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc ('k') | chrome/browser/chromeos/settings/cros_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

diff --git a/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc b/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

index 8634ade1927393baebba996f9d848d18453b7a72..a7ffe0bf188aa84ab6a481a63c219eb0122eccce 100644

--- a/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

+++ b/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

@@ -185,10 +185,8 @@ std::string ValueToString(const base::Value& value) {

}

void AppendAll(const base::ListValue& from, base::ListValue* to) {

- for (base::ListValue::const_iterator it = from.begin(); it != from.end();

- ++it) {

- to->Append((*it)->DeepCopy());

- }

+ for (const auto& value : from)

+ to->Append(value->CreateDeepCopy());

}

// Matcher to match base::Value.