Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos

chrome/browser/chromeos/file_manager/file_browser_handlers.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_manager/file_browser_handlers.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <set>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/i18n/case_conversion.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/file_manager/app_id.h"
 #include "chrome/browser/chromeos/file_manager/fileapi_util.h"
 #include "chrome/browser/chromeos/file_manager/open_with_browser.h"
 #include "chrome/browser/chromeos/fileapi/file_system_backend.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_finder.h"
@@ skipping 354 matching lines @@
   if (!router) {
     ExecuteDoneOnUIThread(false);
     return;
   }
 
   SetupHandlerHostFileAccessPermissions(
       file_definition_list.get(), extension_.get(), handler_pid);
 
   std::unique_ptr<base::ListValue> event_args(new base::ListValue());
   event_args->AppendString(action_id_);
-  base::DictionaryValue* details = new base::DictionaryValue();
-  event_args->Append(details);
+  auto details = base::MakeUnique<base::DictionaryValue>();
   // Get file definitions. These will be replaced with Entry instances by
   // dispatchEvent() method from event_binding.js.
   base::ListValue* file_entries = new base::ListValue();
   details->Set("entries", file_entries);
+  event_args->Append(std::move(details));
 
   for (EntryDefinitionList::const_iterator iter =
            entry_definition_list->begin();
        iter != entry_definition_list->end();
        ++iter) {
-    base::DictionaryValue* file_def = new base::DictionaryValue();
-    file_entries->Append(file_def);
+    auto file_def = base::MakeUnique<base::DictionaryValue>();
+    file_entries->Append(std::move(file_def));

[Daniel Erat, 2016/10/13 17:57:16]

uh... file_def looks like it's still getting used after this. you need to move
this line to the end of the for body, right?

[dcheng, 2016/10/13 19:42:46]

Doh, I missed this one. Done.

     file_def->SetString("fileSystemName", iter->file_system_name);
     file_def->SetString("fileSystemRoot", iter->file_system_root_url);
     file_def->SetString("fileFullPath",
                         "/" + iter->full_path.AsUTF8Unsafe());
     file_def->SetBoolean("fileIsDirectory", iter->is_directory);
   }
 
   std::unique_ptr<extensions::Event> event(new extensions::Event(
       extensions::events::FILE_BROWSER_HANDLER_ON_EXECUTE,
       "fileBrowserHandler.onExecute", std::move(event_args)));
@@ skipping 114 matching lines @@
       if (common_handlers.empty())
         return FileBrowserHandlerList();
     }
   }
 
   return common_handlers;
 }
 
 }  // namespace file_browser_handlers
 }  // namespace file_manager