chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc - Issue 2418833003: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

Issue 2418833003: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos (Closed)

Patch Set: use-after-move Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc ('k') | chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

diff --git a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

index 0b356b4d52d3c23129bc4654545e58ef76da8882..af8f115e6f3f3442ad8c415e119ea33cd75258c7 100644

--- a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

+++ b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

@@ -281,7 +281,7 @@ bool OwnerSettingsServiceChromeOS::AppendToList(const std::string& setting,

std::unique_ptr<base::ListValue> new_value(

old_value ? static_cast<const base::ListValue*>(old_value)->DeepCopy()

: new base::ListValue());

- new_value->Append(value.DeepCopy());

+ new_value->Append(value.CreateDeepCopy());

return Set(setting, *new_value);

}