Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: chrome/browser/chromeos/settings/cros_settings_unittest.cc

Issue 2418833003: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos (Closed)
Patch Set: use-after-move Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/settings/cros_settings.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/settings/cros_settings_unittest.cc
diff --git a/chrome/browser/chromeos/settings/cros_settings_unittest.cc b/chrome/browser/chromeos/settings/cros_settings_unittest.cc
index 7fdf021d40ed2e92a5f1166cf32d7f09e704761d..58bb920358003d3cb556d5207861fca402c13bcd 100644
--- a/chrome/browser/chromeos/settings/cros_settings_unittest.cc
+++ b/chrome/browser/chromeos/settings/cros_settings_unittest.cc
@@ -133,7 +133,7 @@ TEST_F(CrosSettingsTest, SetWhitelist) {
TEST_F(CrosSettingsTest, SetWhitelistWithListOps) {
base::ListValue* whitelist = new base::ListValue();
base::StringValue hacky_user("h@xxor");
- whitelist->Append(hacky_user.DeepCopy());
+ whitelist->Append(hacky_user.CreateDeepCopy());
AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
AddExpectation(kAccountsPrefUsers, whitelist);
// Add some user to the whitelist.
@@ -146,9 +146,9 @@ TEST_F(CrosSettingsTest, SetWhitelistWithListOps2) {
base::ListValue whitelist;
base::StringValue hacky_user("h@xxor");
base::StringValue lamy_user("l@mer");
- whitelist.Append(hacky_user.DeepCopy());
+ whitelist.Append(hacky_user.CreateDeepCopy());
base::ListValue* expected_list = whitelist.DeepCopy();
- whitelist.Append(lamy_user.DeepCopy());
+ whitelist.Append(lamy_user.CreateDeepCopy());
AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
SetPref(kAccountsPrefUsers, &whitelist);
« no previous file with comments | « chrome/browser/chromeos/settings/cros_settings.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698