Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: chrome/browser/chromeos/login/app_launch_signin_screen.cc

Issue 2418833003: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos (Closed)
Patch Set: use-after-move Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/app_launch_signin_screen.cc
diff --git a/chrome/browser/chromeos/login/app_launch_signin_screen.cc b/chrome/browser/chromeos/login/app_launch_signin_screen.cc
index 1356b0d86f55558b689319e5ee29ad7fdb212d4a..8a971e46185d04dceebe1ade16ae5f5ff61684b1 100644
--- a/chrome/browser/chromeos/login/app_launch_signin_screen.cc
+++ b/chrome/browser/chromeos/login/app_launch_signin_screen.cc
@@ -4,6 +4,9 @@
#include "chrome/browser/chromeos/login/app_launch_signin_screen.h"
+#include <utility>
+
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "chrome/browser/chromeos/login/help_app_launcher.h"
#include "chrome/browser/chromeos/login/screens/user_selection_screen.h"
@@ -211,15 +214,13 @@ void AppLaunchSigninScreen::HandleGetUsers() {
UserSelectionScreen::ShouldForceOnlineSignIn(*it)
? proximity_auth::ScreenlockBridge::LockHandler::ONLINE_SIGN_IN
: proximity_auth::ScreenlockBridge::LockHandler::OFFLINE_PASSWORD;
- base::DictionaryValue* user_dict = new base::DictionaryValue();
+ auto user_dict = base::MakeUnique<base::DictionaryValue>();
UserSelectionScreen::FillUserDictionary(
- *it,
- true, /* is_owner */
- false, /* is_signin_to_add */
- initial_auth_type,
- NULL, /* public_session_recommended_locales */
- user_dict);
- users_list.Append(user_dict);
+ *it, true, /* is_owner */
+ false, /* is_signin_to_add */
+ initial_auth_type, NULL, /* public_session_recommended_locales */
+ user_dict.get());
+ users_list.Append(std::move(user_dict));
}
webui_handler_->LoadUsers(users_list, false);

Powered by Google App Engine
This is Rietveld 408576698