Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3173)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_api.cc

Issue 2418833003: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/chromeos (Closed)
Patch Set: use-after-move Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc ('k') | chrome/browser/chromeos/file_manager/file_browser_handlers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/wallpaper_api.cc
diff --git a/chrome/browser/chromeos/extensions/wallpaper_api.cc b/chrome/browser/chromeos/extensions/wallpaper_api.cc
index 080f49db31706ec3ff5e0bdc94e75cfbf4fea147..b78068266209d59728d8f57ea081c42782bf46c9 100644
--- a/chrome/browser/chromeos/extensions/wallpaper_api.cc
+++ b/chrome/browser/chromeos/extensions/wallpaper_api.cc
@@ -248,8 +248,8 @@ void WallpaperSetWallpaperFunction::ThumbnailGenerated(
extensions::EventRouter* event_router =
extensions::EventRouter::Get(profile);
std::unique_ptr<base::ListValue> event_args(new base::ListValue());
- event_args->Append(original_result->DeepCopy());
- event_args->Append(thumbnail_result->DeepCopy());
+ event_args->Append(original_result->CreateDeepCopy());
+ event_args->Append(thumbnail_result->CreateDeepCopy());
event_args->AppendString(
extensions::api::wallpaper::ToString(params_->details.layout));
// Setting wallpaper from right click menu in 'Files' app is a feature that
« no previous file with comments | « chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc ('k') | chrome/browser/chromeos/file_manager/file_browser_handlers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698