Remove PageLoad.Timing2.NavigationToCommit histograms.

Remove PageLoad.Timing2.NavigationToCommit histograms.

This histogram uses a commit time recorded in the browser process,
which is incorrect. Additionally, we are encouraging consumers to
move to 'parse start' since it's a more well defined timestamp in
the render process that is conceptually similar to commit.

Until we have a customer that needs to track actual commit time,
we are removing it. If we need to support this in the future,
we should instrument the commit time properly in the render process
as part of that work.

BUG=654430
Committed: https://crrev.com/ab53067e0c3938944cf7aa9b120811e8a031a4f8
Cr-Commit-Position: refs/heads/master@{#425868}

[Bryan McQuade, 2016-10-14 17:48:07]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 17:48:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-10-14 17:48:49]

Description was changed from

==========
Remove PageLoad.Timing2.NavigationToCommit histograms.

This histogram uses a commit time recorded in the browser process,
which is incorrect. Additionally, we are encouraging consumers to
move to 'parse start' since it's a more well defined timestamp in
the render process that is conceptually similar to commit.

Until we have a customer that needs to track actual commit time,
we are removing it. If we need to support this in the future,
we should instrument the commit time properly in the render process
as part of that work.

BUG=
==========

to

==========
Remove PageLoad.Timing2.NavigationToCommit histograms.

This histogram uses a commit time recorded in the browser process,
which is incorrect. Additionally, we are encouraging consumers to
move to 'parse start' since it's a more well defined timestamp in
the render process that is conceptually similar to commit.

Until we have a customer that needs to track actual commit time,
we are removing it. If we need to support this in the future,
we should instrument the commit time properly in the render process
as part of that work.

BUG=654430
==========

[Bryan McQuade, 2016-10-14 18:33:46]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org

[Bryan McQuade, 2016-10-14 18:33:46]

PTAL

[Bryan McQuade, 2016-10-14 18:35:40]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 18:35:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 20:04:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 20:04:02]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-10-16 01:08:17]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-16 01:08:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-16 02:19:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-16 02:19:14]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-10-17 16:53:38]

lgtm w/ nit.

https://codereview.chromium.org/2418763005/diff/60001/chrome/browser/page_loa...
File
chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc
(right):

https://codereview.chromium.org/2418763005/diff/60001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc:49:
extra_info.committed_url.is_empty())
nit: add {}.

[Bryan McQuade, 2016-10-17 18:45:38]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 18:46:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-10-17 19:10:49]

bmcquade@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Bryan McQuade, 2016-10-17 19:10:50]

Thanks! Fixed. rkaplow, ptal for histograms.xml, thanks!

[commit-bot: I haz the power, 2016-10-17 19:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 19:43:53]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2016-10-17 21:40:12]

lgtm

[Bryan McQuade, 2016-10-18 02:36:00]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2016-10-18 02:36:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2418763005/#ps80001
(title: "address comment")

[commit-bot: I haz the power, 2016-10-18 02:36:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 02:43:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-18 02:46:20]

Description was changed from

==========
Remove PageLoad.Timing2.NavigationToCommit histograms.

This histogram uses a commit time recorded in the browser process,
which is incorrect. Additionally, we are encouraging consumers to
move to 'parse start' since it's a more well defined timestamp in
the render process that is conceptually similar to commit.

Until we have a customer that needs to track actual commit time,
we are removing it. If we need to support this in the future,
we should instrument the commit time properly in the render process
as part of that work.

BUG=654430
==========

to

==========
Remove PageLoad.Timing2.NavigationToCommit histograms.

This histogram uses a commit time recorded in the browser process,
which is incorrect. Additionally, we are encouraging consumers to
move to 'parse start' since it's a more well defined timestamp in
the render process that is conceptually similar to commit.

Until we have a customer that needs to track actual commit time,
we are removing it. If we need to support this in the future,
we should instrument the commit time properly in the render process
as part of that work.

BUG=654430

Committed: https://crrev.com/ab53067e0c3938944cf7aa9b120811e8a031a4f8
Cr-Commit-Position: refs/heads/master@{#425868}
==========

[commit-bot: I haz the power, 2016-10-18 02:46:21]

Patchset 5 (id:??) landed as
https://crrev.com/ab53067e0c3938944cf7aa9b120811e8a031a4f8
Cr-Commit-Position: refs/heads/master@{#425868}