Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Unified Diff: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

Issue 2418763005: Remove PageLoad.Timing2.NavigationToCommit histograms. (Closed)
Patch Set: address comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc
index d9722f25ea73ae56f86e0b8cfe2e232007e0eac2..94dc55025bf74f7a7416014aa99bab8b73e4cc67 100644
--- a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc
@@ -45,8 +45,10 @@ void HttpsEngagementPageLoadMetricsObserver::OnShown() {
void HttpsEngagementPageLoadMetricsObserver::OnComplete(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
- if (!extra_info.committed_url.is_valid() || !extra_info.time_to_commit)
+ if (!extra_info.committed_url.is_valid() ||
+ extra_info.committed_url.is_empty()) {
return;
+ }
// Don't record anything if the user never saw it.
if (!currently_in_foreground_ && foreground_time_.is_zero())

Powered by Google App Engine
This is Rietveld 408576698