Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2418763005: Remove PageLoad.Timing2.NavigationToCommit histograms. (Closed)
Patch Set: address comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index cfb0da450ec106e3f562e2f041b460b46afd51cc..caa38dcd6839e3537f59e870f61aa4afadbd46d0 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -73,11 +73,6 @@ void RecordFirstMeaningfulPaintStatus(
namespace internal {
-const char kHistogramCommit[] = "PageLoad.Timing2.NavigationToCommit";
-
-const char kBackgroundHistogramCommit[] =
- "PageLoad.Timing2.NavigationToCommit.Background";
-
const char kHistogramDomContentLoaded[] =
"PageLoad.DocumentTiming.NavigationToDOMContentLoadedEventFired";
const char kBackgroundHistogramDomContentLoaded[] =
@@ -571,14 +566,6 @@ void CorePageLoadMetricsObserver::OnUserInput(
void CorePageLoadMetricsObserver::RecordTimingHistograms(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
- const base::TimeDelta time_to_commit = info.time_to_commit.value();
- if (WasStartedInForegroundOptionalEventInForeground(info.time_to_commit,
- info)) {
- PAGE_LOAD_HISTOGRAM(internal::kHistogramCommit, time_to_commit);
- } else {
- PAGE_LOAD_HISTOGRAM(internal::kBackgroundHistogramCommit, time_to_commit);
- }
-
// Log time to first foreground / time to first background. Log counts that we
// started a relevant page load in the foreground / background.
if (info.started_in_foreground) {
@@ -624,9 +611,8 @@ void CorePageLoadMetricsObserver::RecordRappor(
rappor::RapporService* rappor_service = g_browser_process->rappor_service();
if (!rappor_service)
return;
- if (!info.time_to_commit)
+ if (info.committed_url.is_empty())
return;
- DCHECK(!info.committed_url.is_empty());
// Log the eTLD+1 of sites that show poor loading performance.
if (WasStartedInForegroundOptionalEventInForeground(

Powered by Google App Engine
This is Rietveld 408576698