chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc - Issue 2418763005: Remove PageLoad.Timing2.NavigationToCommit histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2418763005: Remove PageLoad.Timing2.NavigationToCommit histograms. (Closed)

Patch Set: address comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

index 53b20555e35cc83347e649076ff74458745dbb9c..aa2381b2d2bc48eee7ebe81811644b6679fbe73e 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

@@ -114,7 +114,6 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, SameUrlNavigation) {

NavigateToUntrackedUrl();

// We expect one histogram sample for each navigation to title1.html.

- histogram_tester_.ExpectTotalCount(internal::kHistogramCommit, 2);

histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 2);

histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 2);

histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 2);