Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2418763005: Remove PageLoad.Timing2.NavigationToCommit histograms. (Closed)
Patch Set: address comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/scoped_temp_dir.h" 5 #include "base/files/scoped_temp_dir.h"
6 #include "base/macros.h" 6 #include "base/macros.h"
7 #include "base/test/histogram_tester.h" 7 #include "base/test/histogram_tester.h"
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" 9 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
10 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h" 10 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, SameUrlNavigation) { 107 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, SameUrlNavigation) {
108 ASSERT_TRUE(embedded_test_server()->Start()); 108 ASSERT_TRUE(embedded_test_server()->Start());
109 109
110 ui_test_utils::NavigateToURL(browser(), 110 ui_test_utils::NavigateToURL(browser(),
111 embedded_test_server()->GetURL("/title1.html")); 111 embedded_test_server()->GetURL("/title1.html"));
112 ui_test_utils::NavigateToURL(browser(), 112 ui_test_utils::NavigateToURL(browser(),
113 embedded_test_server()->GetURL("/title1.html")); 113 embedded_test_server()->GetURL("/title1.html"));
114 NavigateToUntrackedUrl(); 114 NavigateToUntrackedUrl();
115 115
116 // We expect one histogram sample for each navigation to title1.html. 116 // We expect one histogram sample for each navigation to title1.html.
117 histogram_tester_.ExpectTotalCount(internal::kHistogramCommit, 2);
118 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 2); 117 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 2);
119 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 2); 118 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 2);
120 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 2); 119 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 2);
121 } 120 }
122 121
123 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, NonHtmlMainResource) { 122 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, NonHtmlMainResource) {
124 ASSERT_TRUE(embedded_test_server()->Start()); 123 ASSERT_TRUE(embedded_test_server()->Start());
125 124
126 ui_test_utils::NavigateToURL(browser(), 125 ui_test_utils::NavigateToURL(browser(),
127 embedded_test_server()->GetURL("/circle.svg")); 126 embedded_test_server()->GetURL("/circle.svg"));
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
529 528
530 histogram_tester_.ExpectTotalCount( 529 histogram_tester_.ExpectTotalCount(
531 prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName( 530 prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(
532 prerender::ORIGIN_NONE, false, true, base::TimeDelta()), 531 prerender::ORIGIN_NONE, false, true, base::TimeDelta()),
533 1); 532 1);
534 histogram_tester_.ExpectTotalCount( 533 histogram_tester_.ExpectTotalCount(
535 prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName( 534 prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(
536 prerender::ORIGIN_NONE, false, false, base::TimeDelta()), 535 prerender::ORIGIN_NONE, false, false, base::TimeDelta()),
537 0); 536 0);
538 } 537 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698