Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2418763005: Remove PageLoad.Timing2.NavigationToCommit histograms. (Closed)
Patch Set: address comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
index bf5df59f8d3208fbd3ba4150dcecaf29c11f4016..3ce5eaf819cd93645d48654c97bb3ec23b56eac1 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
@@ -73,7 +73,6 @@ struct PageLoadExtraInfo {
bool user_gesture,
const GURL& committed_url,
const GURL& start_url,
- const base::Optional<base::TimeDelta>& time_to_commit,
UserAbortType abort_type,
bool abort_user_initiated,
const base::Optional<base::TimeDelta>& time_to_abort,
@@ -105,9 +104,6 @@ struct PageLoadExtraInfo {
// The URL that started the navigation, before redirects.
const GURL start_url;
- // Time from navigation start until commit.
- const base::Optional<base::TimeDelta> time_to_commit;
-
// The abort time and time to abort for this page load. If the page was not
// aborted, |abort_type| will be |ABORT_NONE|.
const UserAbortType abort_type;
@@ -234,10 +230,10 @@ class PageLoadMetricsObserver {
// the application may be killed at any time after this method is invoked
// without further notification. Note that this may be called both for
// provisional loads as well as committed loads. Implementations that only
- // want to track committed loads should check extra_info.time_to_commit to
- // determine if the load had committed. If the implementation returns
- // CONTINUE_OBSERVING, this method may be called multiple times per observer,
- // once for each time that the application enters the backround.
+ // want to track committed loads should check whether extra_info.committed_url
+ // is empty to determine if the load had committed. If the implementation
+ // returns CONTINUE_OBSERVING, this method may be called multiple times per
+ // observer, once for each time that the application enters the backround.
//
// The default implementation does nothing, and returns CONTINUE_OBSERVING.
virtual ObservePolicy FlushMetricsOnAppEnterBackground(

Powered by Google App Engine
This is Rietveld 408576698