chrome/browser/page_load_metrics/page_load_metrics_observer.cc - Issue 2418763005: Remove PageLoad.Timing2.NavigationToCommit histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2418763005: Remove PageLoad.Timing2.NavigationToCommit histograms. (Closed)

Patch Set: address comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

index 04fc547986fbfd340a2130249eccd513f6006d45..effb9aa2f5d90d6ba983326c3bd314135edfd5d9 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

@@ -13,7 +13,6 @@ PageLoadExtraInfo::PageLoadExtraInfo(

bool user_gesture,

const GURL& committed_url,

const GURL& start_url,

- const base::Optional<base::TimeDelta>& time_to_commit,

UserAbortType abort_type,

bool abort_user_initiated,

const base::Optional<base::TimeDelta>& time_to_abort,

@@ -26,7 +25,6 @@ PageLoadExtraInfo::PageLoadExtraInfo(

user_gesture(user_gesture),

committed_url(committed_url),

start_url(start_url),

- time_to_commit(time_to_commit),

abort_type(abort_type),

abort_user_initiated(abort_user_initiated),

time_to_abort(time_to_abort),