Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2418763005: Remove PageLoad.Timing2.NavigationToCommit histograms. (Closed)
Patch Set: address comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h" 5 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
6 6
7 namespace page_load_metrics { 7 namespace page_load_metrics {
8 8
9 PageLoadExtraInfo::PageLoadExtraInfo( 9 PageLoadExtraInfo::PageLoadExtraInfo(
10 const base::Optional<base::TimeDelta>& first_background_time, 10 const base::Optional<base::TimeDelta>& first_background_time,
11 const base::Optional<base::TimeDelta>& first_foreground_time, 11 const base::Optional<base::TimeDelta>& first_foreground_time,
12 bool started_in_foreground, 12 bool started_in_foreground,
13 bool user_gesture, 13 bool user_gesture,
14 const GURL& committed_url, 14 const GURL& committed_url,
15 const GURL& start_url, 15 const GURL& start_url,
16 const base::Optional<base::TimeDelta>& time_to_commit,
17 UserAbortType abort_type, 16 UserAbortType abort_type,
18 bool abort_user_initiated, 17 bool abort_user_initiated,
19 const base::Optional<base::TimeDelta>& time_to_abort, 18 const base::Optional<base::TimeDelta>& time_to_abort,
20 int num_cache_requests, 19 int num_cache_requests,
21 int num_network_requests, 20 int num_network_requests,
22 const PageLoadMetadata& metadata) 21 const PageLoadMetadata& metadata)
23 : first_background_time(first_background_time), 22 : first_background_time(first_background_time),
24 first_foreground_time(first_foreground_time), 23 first_foreground_time(first_foreground_time),
25 started_in_foreground(started_in_foreground), 24 started_in_foreground(started_in_foreground),
26 user_gesture(user_gesture), 25 user_gesture(user_gesture),
27 committed_url(committed_url), 26 committed_url(committed_url),
28 start_url(start_url), 27 start_url(start_url),
29 time_to_commit(time_to_commit),
30 abort_type(abort_type), 28 abort_type(abort_type),
31 abort_user_initiated(abort_user_initiated), 29 abort_user_initiated(abort_user_initiated),
32 time_to_abort(time_to_abort), 30 time_to_abort(time_to_abort),
33 num_cache_requests(num_cache_requests), 31 num_cache_requests(num_cache_requests),
34 num_network_requests(num_network_requests), 32 num_network_requests(num_network_requests),
35 metadata(metadata) {} 33 metadata(metadata) {}
36 34
37 PageLoadExtraInfo::PageLoadExtraInfo(const PageLoadExtraInfo& other) = default; 35 PageLoadExtraInfo::PageLoadExtraInfo(const PageLoadExtraInfo& other) = default;
38 36
39 PageLoadExtraInfo::~PageLoadExtraInfo() {} 37 PageLoadExtraInfo::~PageLoadExtraInfo() {}
(...skipping 17 matching lines...) Expand all
57 } 55 }
58 56
59 PageLoadMetricsObserver::ObservePolicy 57 PageLoadMetricsObserver::ObservePolicy
60 PageLoadMetricsObserver::FlushMetricsOnAppEnterBackground( 58 PageLoadMetricsObserver::FlushMetricsOnAppEnterBackground(
61 const PageLoadTiming& timing, 59 const PageLoadTiming& timing,
62 const PageLoadExtraInfo& extra_info) { 60 const PageLoadExtraInfo& extra_info) {
63 return CONTINUE_OBSERVING; 61 return CONTINUE_OBSERVING;
64 } 62 }
65 63
66 } // namespace page_load_metrics 64 } // namespace page_load_metrics
OLDNEW
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_observer.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698