Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2339)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.h

Issue 2418763005: Remove PageLoad.Timing2.NavigationToCommit histograms. (Closed)
Patch Set: address comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/metrics_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.h
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
index d52a54cde7e652f03eede2e91a35f44d1b3a97d1..3d6daece59a17bb31c4fb1ed0d43619187a96c06 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
@@ -201,8 +201,8 @@ class PageLoadTracker {
// Only valid to call post-commit.
const GURL& committed_url() const {
- DCHECK(!commit_time_.is_null());
- return url_;
+ DCHECK(!committed_url_.is_empty());
+ return committed_url_;
}
base::TimeTicks navigation_start() const { return navigation_start_; }
@@ -242,13 +242,8 @@ class PageLoadTracker {
// The navigation start in TimeTicks, not the wall time reported by Blink.
const base::TimeTicks navigation_start_;
- // Time this page load was committed. If this page load hasn't committed,
- // |commit_time_| will be zero.
- base::TimeTicks commit_time_;
-
- // The URL of this page load. This is the provisional url before commit
- // (before redirects), and the committed url after commit.
- GURL url_;
+ // The committed URL of this page load.
+ GURL committed_url_;
// The start URL for this page load (before redirects).
GURL start_url_;
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/metrics_web_contents_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698