Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Yang, v8-mips-ports_googlegroups.com, rmcilroy, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" This reverts commit 7db0ecdec3cf330766575cb7973b983f3f1e3020. Manual revert since automatic revert is too large for the web interface. BUG= TBR=bmeurer@chromium.org,mstarzinger@chromium.org,yangguo@chromium.org,ahaas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true Committed: https://crrev.com/d1545f8eccf0e22e428d911d93b979c5f04db1b8 Cr-Commit-Position: refs/heads/master@{#40082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -460 lines) Patch
M src/accessors.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/scopeinfo.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/builtins/builtins-array.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-dataview.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-function.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-math.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-string.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/builtins/x87/builtins-x87.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/code-stub-assembler.cc View 6 chunks +9 lines, -6 lines 0 comments Download
M src/code-stubs.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/lithium-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/date.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/elements.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M src/field-type.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 6 chunks +10 lines, -6 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/heap/heap.cc View 18 chunks +27 lines, -26 lines 0 comments Download
M src/heap/heap-inl.h View 3 chunks +10 lines, -8 lines 0 comments Download
M src/heap/incremental-marking.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 10 chunks +16 lines, -16 lines 0 comments Download
M src/heap/spaces.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x64/ic-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/keys.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/layout-descriptor-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/objects.cc View 15 chunks +27 lines, -24 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 11 chunks +16 lines, -14 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/property.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/jsregexp.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M src/runtime/runtime-array.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-collections.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-literals.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-strings.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/snapshot/deserializer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/snapshot/serializer-common.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/transitions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/transitions-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/type-feedback-vector.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/wasm/wasm-module.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 15 chunks +31 lines, -27 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-dictionary.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396353002/1
4 years, 2 months ago (2016-10-07 11:43:35 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25929)
4 years, 2 months ago (2016-10-07 11:49:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396353002/1
4 years, 2 months ago (2016-10-07 11:54:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396353002/1
4 years, 2 months ago (2016-10-07 12:21:53 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 12:22:38 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 12:23:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1545f8eccf0e22e428d911d93b979c5f04db1b8
Cr-Commit-Position: refs/heads/master@{#40082}

Powered by Google App Engine
This is Rietveld 408576698