Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls"

src/runtime/runtime-strings.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/runtime/runtime-utils.h"
 
 #include "src/arguments.h"
 #include "src/regexp/jsregexp-inl.h"
 #include "src/string-builder.h"
 #include "src/string-search.h"
@@ skipping 238 matching lines @@
     case ComparisonResult::kLessThan:
       return Smi::FromInt(LESS);
     case ComparisonResult::kEqual:
       return Smi::FromInt(EQUAL);
     case ComparisonResult::kGreaterThan:
       return Smi::FromInt(GREATER);
     case ComparisonResult::kUndefined:
       break;
   }
   UNREACHABLE();
-  return Smi::kZero;
+  return Smi::FromInt(0);
 }
 
 
 RUNTIME_FUNCTION(Runtime_StringBuilderConcat) {
   HandleScope scope(isolate);
   DCHECK(args.length() == 3);
   CONVERT_ARG_HANDLE_CHECKED(JSArray, array, 0);
   int32_t array_length;
   if (!args[1]->ToInt32(&array_length)) {
     THROW_NEW_ERROR_RETURN_FAILURE(isolate, NewInvalidStringLengthError());
@@ skipping 296 matching lines @@
   FixedArray* one_byte_cache = heap->single_character_string_cache();
   Object* undefined = heap->undefined_value();
   int i;
   WriteBarrierMode mode = elements->GetWriteBarrierMode(no_gc);
   for (i = 0; i < length; ++i) {
     Object* value = one_byte_cache->get(chars[i]);
     if (value == undefined) break;
     elements->set(i, value, mode);
   }
   if (i < length) {
-    DCHECK(Smi::kZero == 0);
+    DCHECK(Smi::FromInt(0) == 0);
     memset(elements->data_start() + i, 0, kPointerSize * (length - i));
   }
 #ifdef DEBUG
   for (int j = 0; j < length; ++j) {
     Object* element = elements->get(j);
-    DCHECK(element == Smi::kZero ||
+    DCHECK(element == Smi::FromInt(0) ||
            (element->IsString() && String::cast(element)->LooksValid()));
   }
 #endif
   return i;
 }
 
 
 // Converts a String to JSArray.
 // For example, "foo" => ["f", "o", "o"].
 RUNTIME_FUNCTION(Runtime_StringToArray) {
@@ skipping 342 matching lines @@
   switch (String::Compare(x, y)) {
     case ComparisonResult::kLessThan:
       return isolate->heap()->true_value();
     case ComparisonResult::kEqual:
     case ComparisonResult::kGreaterThan:
       return isolate->heap()->false_value();
     case ComparisonResult::kUndefined:
       break;
   }
   UNREACHABLE();
-  return Smi::kZero;
+  return Smi::FromInt(0);
 }
 
 RUNTIME_FUNCTION(Runtime_StringLessThanOrEqual) {
   HandleScope handle_scope(isolate);
   DCHECK_EQ(2, args.length());
   CONVERT_ARG_HANDLE_CHECKED(String, x, 0);
   CONVERT_ARG_HANDLE_CHECKED(String, y, 1);
   switch (String::Compare(x, y)) {
     case ComparisonResult::kEqual:
     case ComparisonResult::kLessThan:
       return isolate->heap()->true_value();
     case ComparisonResult::kGreaterThan:
       return isolate->heap()->false_value();
     case ComparisonResult::kUndefined:
       break;
   }
   UNREACHABLE();
-  return Smi::kZero;
+  return Smi::FromInt(0);
 }
 
 RUNTIME_FUNCTION(Runtime_StringGreaterThan) {
   HandleScope handle_scope(isolate);
   DCHECK_EQ(2, args.length());
   CONVERT_ARG_HANDLE_CHECKED(String, x, 0);
   CONVERT_ARG_HANDLE_CHECKED(String, y, 1);
   switch (String::Compare(x, y)) {
     case ComparisonResult::kGreaterThan:
       return isolate->heap()->true_value();
     case ComparisonResult::kEqual:
     case ComparisonResult::kLessThan:
       return isolate->heap()->false_value();
     case ComparisonResult::kUndefined:
       break;
   }
   UNREACHABLE();
-  return Smi::kZero;
+  return Smi::FromInt(0);
 }
 
 RUNTIME_FUNCTION(Runtime_StringGreaterThanOrEqual) {
   HandleScope handle_scope(isolate);
   DCHECK_EQ(2, args.length());
   CONVERT_ARG_HANDLE_CHECKED(String, x, 0);
   CONVERT_ARG_HANDLE_CHECKED(String, y, 1);
   switch (String::Compare(x, y)) {
     case ComparisonResult::kEqual:
     case ComparisonResult::kGreaterThan:
       return isolate->heap()->true_value();
     case ComparisonResult::kLessThan:
       return isolate->heap()->false_value();
     case ComparisonResult::kUndefined:
       break;
   }
   UNREACHABLE();
-  return Smi::kZero;
+  return Smi::FromInt(0);
 }
 
 RUNTIME_FUNCTION(Runtime_StringEqual) {
   HandleScope handle_scope(isolate);
   DCHECK_EQ(2, args.length());
   CONVERT_ARG_HANDLE_CHECKED(String, x, 0);
   CONVERT_ARG_HANDLE_CHECKED(String, y, 1);
   return isolate->heap()->ToBoolean(String::Equals(x, y));
 }
 
@@ skipping 36 matching lines @@
   SealHandleScope shs(isolate);
   DCHECK(args.length() == 2);
   if (!args[0]->IsString()) return isolate->heap()->undefined_value();
   if (!args[1]->IsNumber()) return isolate->heap()->undefined_value();
   if (std::isinf(args.number_at(1))) return isolate->heap()->nan_value();
   return __RT_impl_Runtime_StringCharCodeAtRT(args, isolate);
 }
 
 }  // namespace internal
 }  // namespace v8