Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: src/full-codegen/s390/full-codegen-s390.cc

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/s390/full-codegen-s390.cc
diff --git a/src/full-codegen/s390/full-codegen-s390.cc b/src/full-codegen/s390/full-codegen-s390.cc
index d0e7adb70de0ead4b85e414d9390cd75893c7184..8a50eeec9d195ae0e1d2c80130b1147cad8aaeaa 100644
--- a/src/full-codegen/s390/full-codegen-s390.cc
+++ b/src/full-codegen/s390/full-codegen-s390.cc
@@ -363,7 +363,7 @@ void FullCodeGenerator::Generate() {
}
void FullCodeGenerator::ClearAccumulator() {
- __ LoadSmiLiteral(r2, Smi::kZero);
+ __ LoadSmiLiteral(r2, Smi::FromInt(0));
}
void FullCodeGenerator::EmitProfilingCounterDecrement(int delta) {
@@ -984,7 +984,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {
__ bind(&use_cache);
__ EnumLength(r3, r2);
- __ CmpSmiLiteral(r3, Smi::kZero, r0);
+ __ CmpSmiLiteral(r3, Smi::FromInt(0), r0);
__ beq(&no_descriptors, Label::kNear);
__ LoadInstanceDescriptors(r2, r4);
@@ -994,7 +994,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {
// Set up the four remaining stack slots.
__ push(r2); // Map.
- __ LoadSmiLiteral(r2, Smi::kZero);
+ __ LoadSmiLiteral(r2, Smi::FromInt(0));
// Push enumeration cache, enumeration cache length (as smi) and zero.
__ Push(r4, r3, r2);
__ b(&loop);
@@ -1011,7 +1011,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {
__ LoadP(r3, FieldMemOperand(r2, FixedArray::kLengthOffset));
__ Push(r3); // Fixed array length (as smi).
PrepareForBailoutForId(stmt->PrepareId(), BailoutState::NO_REGISTERS);
- __ LoadSmiLiteral(r2, Smi::kZero);
+ __ LoadSmiLiteral(r2, Smi::FromInt(0));
__ Push(r2); // Initial index.
// Generate code for doing the condition check.
@@ -1896,7 +1896,7 @@ void FullCodeGenerator::EmitInlineSmiBinaryOp(BinaryOperation* expr,
__ AddP(scratch2, right, left);
__ CmpP(scratch2, Operand::Zero());
__ blt(&stub_call);
- __ LoadSmiLiteral(right, Smi::kZero);
+ __ LoadSmiLiteral(right, Smi::FromInt(0));
break;
}
case Token::BIT_OR:
@@ -2995,7 +2995,7 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
} else {
// Reserve space for result of postfix operation.
if (expr->is_postfix() && !context()->IsEffect()) {
- __ LoadSmiLiteral(ip, Smi::kZero);
+ __ LoadSmiLiteral(ip, Smi::FromInt(0));
PushOperand(ip);
}
switch (assign_type) {
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698