src/arm64/macro-assembler-arm64.cc - Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/macro-assembler-arm64.cc

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/macro-assembler-arm64.cc

diff --git a/src/arm64/macro-assembler-arm64.cc b/src/arm64/macro-assembler-arm64.cc

index e5a2969924358be7a8826d97776dd9a7df0f459c..87ea1eb9d5910c333317bbbec63733325680eb0f 100644

--- a/src/arm64/macro-assembler-arm64.cc

+++ b/src/arm64/macro-assembler-arm64.cc

@@ -3830,7 +3830,7 @@ void MacroAssembler::EmitSeqStringSetCharCheck(

Cmp(index, index_type == kIndexIsSmi ? scratch : Operand::UntagSmi(scratch));

Check(lt, kIndexIsTooLarge);

- DCHECK_EQ(static_cast<Smi*>(0), Smi::kZero);

+ DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0));

Cmp(index, 0);

Check(ge, kIndexIsNegative);

}

« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/ast/ast.cc » ('j') | no next file with comments »