src/ic/arm64/ic-arm64.cc - Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/arm64/ic-arm64.cc

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/arm64/ic-arm64.cc

diff --git a/src/ic/arm64/ic-arm64.cc b/src/ic/arm64/ic-arm64.cc

index 790917fcdf223b54473bfa4d02b4f07a2864b852..fa9d7c16b76a3bc0d9c58abca4bb735159ffd4c8 100644

--- a/src/ic/arm64/ic-arm64.cc

+++ b/src/ic/arm64/ic-arm64.cc

@@ -181,7 +181,7 @@ static void GenerateFastArrayLoad(MacroAssembler* masm, Register receiver,

// Out of bounds. Check the prototype chain to see if we can just return

// 'undefined'.

- __ Cmp(key, Operand(Smi::kZero));

+ __ Cmp(key, Operand(Smi::FromInt(0)));

__ B(lt, slow); // Negative keys can't take the fast OOB path.

__ Bind(&check_prototypes);

__ Ldr(scratch2, FieldMemOperand(receiver, HeapObject::kMapOffset));

« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/ic/x64/ic-x64.cc » ('j') | no next file with comments »